Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Anchor position update #645

Merged
merged 7 commits into from
Jul 2, 2024
Merged

Add Anchor position update #645

merged 7 commits into from
Jul 2, 2024

Conversation

jamesnw
Copy link
Contributor

@jamesnw jamesnw commented Jun 27, 2024

Copy link

View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..anchor-update

@jamesnw jamesnw linked an issue Jun 27, 2024 that may be closed by this pull request
Copy link
Contributor

@SondraE SondraE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few things that you could consider updating.

  1. In the blurb, I found myself unsure what "support" referred to. Browser support? Financial support? So here are ideas for clarifying that just a bit.
    "Sponsor support for continued development of the Anchor Position Spec is making the Anchor Position Polyfill more useful. Here's a summary of the latest updates."
    OR
    "Donations from sponsors for continued development of the Anchor Position Spec is making the Anchor Position Polyfill more useful. Here's what's new!"

  2. "some of the upcoming ones are-" I would change that to "some of the upcoming ones are:" (Use a colon instead of a dash.)

  3. At most screen sizes that I have available to view the header image, I can't see the bottom of the anchor. I see the chains, mostly. Could you re-position the image so that the really recognizable part of the anchor is in view on more screen sizes?

@jamesnw
Copy link
Contributor Author

jamesnw commented Jul 1, 2024

@SondraE Updated in fc9377b

content/blog/2024/anchor-position-polyfill.md Outdated Show resolved Hide resolved
content/blog/2024/anchor-position-polyfill.md Outdated Show resolved Hide resolved
content/blog/2024/anchor-position-polyfill.md Outdated Show resolved Hide resolved
content/blog/2024/anchor-position-polyfill.md Outdated Show resolved Hide resolved
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
@jamesnw jamesnw merged commit 0cabaa4 into main Jul 2, 2024
10 checks passed
@jamesnw jamesnw deleted the anchor-update branch July 2, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A blog post updating on Anchor Position
3 participants