Fix updating task name when clearing task from card. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ran into this minor bug while working on fixing time summaries. If you clear a task from a card, it wasn't removing the previous task name from the "time report" card section. So I fixed it.
Steps to test/reproduce
Open a card with a task assigned to it, edit the assigned task and choose
--clear--. The time-report card section should update to say "The Harvest task for this card is not set." Before this fix it wouldn't update, it would still say "The Harvest task for this card is previously-assigned-task." (The time report always did update, just not the task name.)Reviewer tasks:
You're welcome to pull the code locally to verify the fix if you want, but given the fix is small and it's kind of a hassle to set up Oddvest for local dev, I think you could just trust my manual testing and just review the code :)