Switch to Dart Sass and Sass modules. #348
Conversation
* bug-rem-size: Rebuild size/font preview styles
* bug-rem-size: Add missing macro arg
* bug-rem-size: Update changelog, docs
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 24
Lines ? 997
Branches ? 220
==========================================
Hits ? 997
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
* master:
* master: node v6 was already broken so just admit it Try to pin deps to work on node6. Try to pin deps to work on node6.
* master: Bump lodash from 4.17.15 to 4.17.19
|
@jgerigmeyer I've updated all the Sass to use modules - but I can't get the sass examples to compile correctly. Can you take a look? |
| ); | ||
|
|
||
| tools.$functions: $functions; |
There was a problem hiding this comment.
@mirisuzanne This seems like an underlying bug in Sassdoc -- I guess it doesn't know that tools.$functions is a variable declaration?
| @@ -207,7 +207,7 @@ $demo-noncolors: ( | |||
| /// meta.get-function('color', $module: 'tools') // function | |||
| /// ); | |||
| /// | |||
| /// @each $key, $value in $herman { | |||
| /// @each $key, $value in utilities.$herman { | |||
There was a problem hiding this comment.
@mirisuzanne I'm not sure I caught all of the places where this should be changed, but this is what was breaking the build.
webpack.config.js
Outdated
| @@ -39,7 +39,6 @@ const sassDocOpts = { | |||
| templatePath: path.join(__dirname, 'templates'), | |||
| }, | |||
| sass: { | |||
| implementation: 'sass', | |||
There was a problem hiding this comment.
- Dart Sass is the default
- This needs to be an actual instance (e.g.
implementation: require('sass')), not a string
|
@mirisuzanne Back to you. |
|
@mirisuzanne Next step is probably to merge this and do an RC release to test out on a few projects? |
Todo: