Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflows #163

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Add workflows #163

merged 1 commit into from
Aug 27, 2022

Conversation

Serial-ATA
Copy link
Contributor

This adds 2 workflows, one builds all of the projects and uploads the artifacts, the other checks that PR commit messages follow the Conventional Commits style.

@oddlama
Copy link
Owner

oddlama commented Aug 27, 2022

Thanks, this looks awesome!

But I'm currently not sure what the intended purpose of the uploaded artifacts is. How would they be used in your opinion?

@Serial-ATA
Copy link
Contributor Author

I've been looking at the workflows of other plugins, and all of the ones I've seen upload artifacts just to make dev builds more accessible I assume.

@oddlama
Copy link
Owner

oddlama commented Aug 27, 2022

Ah that makes sense. It the current state the dev builds would be slightly dysfunctional though:
When building vane, the SHA1 sum of the associated resource pack (from the github docs/resourcepacks folder) will be included into the JAR file. So those builds will break if the version is bumped. I'm not sure how severe the failing action would be.

I'm curious though, what plugins did you look at?

@Serial-ATA
Copy link
Contributor Author

Here are a few:

If these builds are subject to breakage, that should probably be noted here too.

@oddlama
Copy link
Owner

oddlama commented Aug 27, 2022

Thanks for the pointers :)

It's actually not too big of an issue, because you don't randomly bump the version in PRs, as that would only be done by a maintainer (so currently by me) on a new release. So the builds wouldn't break for anyone but me.

Currently there isn't a lot of accessible documentation about the vane framework, so that would be something to improve in the future, and that's where this should definitely be mentioned.

I'll have a closer look at this PR tomorrow (it's late for me now).

@Serial-ATA
Copy link
Contributor Author

Forgot, here's the message you'll get when you have an invalid commit message: Serial-ATA#2 (comment)

@oddlama oddlama merged commit 73e9a55 into oddlama:develop Aug 27, 2022
@Serial-ATA Serial-ATA deleted the workflows branch August 27, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants