Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian translation #40

Merged
merged 5 commits into from
Aug 15, 2021
Merged

Russian translation #40

merged 5 commits into from
Aug 15, 2021

Conversation

RozeFound
Copy link
Contributor

Just russian translation.

I've seen #32 , it's a trash. He used google translate and even doesn't look at the result.

@oddlama oddlama mentioned this pull request Aug 13, 2021
@oddlama
Copy link
Owner

oddlama commented Aug 13, 2021

Wow thanks for the heads up and for putting in the actual work!

Let me know when you have tested this enough to ensure that everything works as expected and I will include it in the next release. Unfortunately this will be at the end of next month as I'm a little busy right now IRL.

@RozeFound
Copy link
Contributor Author

I'm not using all of your plugins, but okay I will test all in a free time.

@RozeFound
Copy link
Contributor Author

RozeFound commented Aug 14, 2021

And in your plugins too many duplicated strings (like "Cancel" and literally the whole portals), can you do something with it? It's really annoying to copy-paste the same thing 10 times

@oddlama
Copy link
Owner

oddlama commented Aug 14, 2021

I'm not using all of your plugins, but okay I will test all in a free time.

No worries, I wanted to make sure you are finished before merging.
I just can't read Russian, so it's hard to judge whether a translation is fully finished or still work-in-progress.

And in your plugins too many duplicated strings (like "Cancel" and literally the whole portals), can you do something with it? It's really annoying to copy-paste the same thing 10 times

That's true, but the way the configuration works unfortunately requires this duplication. Sure it's a little annoying, but a good editor should be able to help with repeating tasks. (VSCode's multiple cursors, or vim's macros and context aware replacements).

At this point it's hard to improve without switching to a new config format. While YAML supports node references, they can only be used when the whole string is the same, and I'm also not sure how mature Spigot/PaperMC's YAML configuration parser actually is.

@RozeFound
Copy link
Contributor Author

RozeFound commented Aug 14, 2021

I just can't read Russian, so it's hard to judge whether a translation is fully finished or still work-in-progress.

Translate is complete, but there may be formatting issues or something.

@RozeFound
Copy link
Contributor Author

And how to translate time literals? I want to see 18м13с instead of 18m13s

@RozeFound
Copy link
Contributor Author

And what is region group?

@oddlama
Copy link
Owner

oddlama commented Aug 14, 2021

Firstly, players can create regions which allows them to manage permissions inside them. For example you can disable that
other players can build inside the region or that they can use chests.

When you have several regions, it would become a hassle to manage the permissions for each region separately. Therefore every region is automatically assigned to a region group, which determines the permissions for all regions that belong to it. So I can create a region group for "Shared property with my friends", where I set the permissions such that my friends can do everything, but all other players have no permissions.

Now when I create a new region and assign it to this region group, it automatically has the correct permissions. As every region must belong to exactly one region group, there is one default region group, to which all newly created regions are added by default. It is usually the group for "Only the owner can build and use chests".

EDIT: Regarding your previous question, translating literals isn't supported at the moment. I can add support for this in the future.

@RozeFound
Copy link
Contributor Author

RozeFound commented Aug 15, 2021

For simplier understanding, region group it's just bunch of regions, right?
Just I translated it more like "Group of Regions" in english, and I'm not sure if it accurate.
The second variant is "Regional group" I thinks about.
Both seems to not really accurate, but there are no straight translation for "Region Group" in Russian.

Edit: Oh, I think I found something suitable.

@RozeFound
Copy link
Contributor Author

Now I can say it's fully finished.

@oddlama
Copy link
Owner

oddlama commented Aug 15, 2021

Both seems to not really accurate, but there are no straight translation for "Region Group" in Russian.

I had the same problem with the German translation, in the end I opted for something that means "Group for Regions" / "Group of a Region" when translated literally. As long as it is somehow apparent that Regions relate to these Groups, the exact translation doesn't matter all that much. If people are using the regions feature, they will probably have seen the feature overview page, which explains this in more detail (in English). It's hard explaining such a high-level concept like this in just a few words inside of a Minecraft item lore. It may even be impossible without at least creating some confusion. So I'm glad you found a translation you like, and I'm sure it is absolutely sufficient.

Thanks a lot for contributing!

@oddlama oddlama merged commit 2a32f52 into oddlama:master Aug 15, 2021
@RozeFound
Copy link
Contributor Author

That was easy because of really small amount of text. Feel free to contact me when you will need to update translation. You can just mention me in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants