Update WNFS & UnixFS compat layer #536
Conversation
icidasset
force-pushed
the
icidasset/update-wnfs
branch
2 times, most recently
from
b5488fc
to
c559cc3
Compare
icidasset
force-pushed
the
icidasset/update-wnfs
branch
from
c927433
to
5268044
Compare
icidasset
force-pushed
the
icidasset/update-wnfs
branch
from
cfe9342
to
60039f6
Compare
icidasset
force-pushed
the
icidasset/update-wnfs
branch
from
2697ccf
to
cfd0600
Compare
There was a problem hiding this comment.
unixfs.ts looks like what I'd expect :) 👍
Keep in mind, we'll be doing a release of rs-wnfs in like, just an hour or so. That'll make your tests run faster.
Also, have you tried using rs-wnfs' native .cp function in the case where you're copying files or directories within the private partition? It should be a little faster than doing more round-trips from JS to Wasm.
And after the new rs-wnfs release, there will also be a public filesystem cp function.
| export async function createPrivateForest(): Promise<PrivateForest> { | ||
| const rng = makeRngInterface() | ||
| const rsaKey = await Crypto.rsa.generateKey("sign") | ||
| const rsaMod = await webcrypto.subtle | ||
| .exportKey("jwk", rsaKey.publicKey) | ||
| .then(a => { | ||
| if (a.n) return a.n | ||
| else throw new Error("Expected public RSA key to have `n` property") | ||
| }) | ||
| .then(n => Uint8Arrays.fromString(n, "base64url")) | ||
|
|
||
| return new PrivateForest(rng, rsaMod) | ||
| } |
| * Events interface. | ||
| * | ||
| * Subscribe to events using `on` and unsubscribe using `off`. | ||
| * There's also `once`, `onAny`, `offAny`, `anyEvent` and `events`. |
| * @group Querying | ||
| */ | ||
| permalink(dataRoot: CID, path: Path.Distinctive<Path.Partitioned<Path.Partition>>): string { | ||
| if (this.#dependencies.depot.permalink) { |
There was a problem hiding this comment.
note: when i started integrating the ts-odd next branch into collector this week I had to add this babel plugin to handle # methods:
@babel/plugin-transform-private-methods
This may just be a quirk of react-native(I haven't tried the latest updates in a svelte app yet), but perhaps it's something we want to highlight in the readme?
There was a problem hiding this comment.
Ah good point, maybe it’s because it’s a relatively new js feature (2021), ecmascript 2022 I think. The readme still needs to be rewritten but yeah we should definitely mention that. Can you change the compile target to es2022 in react native?
There was a problem hiding this comment.
looks like I can! It's strange, the app extends the expo config, which specifies a target of ESNext, which seems like it should have that functionality, but specifying ES2022 explicitly seems to fix it 👌🏼
There was a problem hiding this comment.
Nice 👍 Yeah, esnext is confusing because it depends on when they last updated the pointer (could even be es2020 🤷). I'll mention in the readme that the SDK requires es2022.
| } | ||
|
|
||
| //////// | ||
| // ㊙️ // |
There was a problem hiding this comment.
I still find the emoji section headers a bit confusing 🙈 after some searching, it looks like this means secret? ㊙️ Should we just add the word Secret to these sections? May be clearer for outside contributors 🤔
There was a problem hiding this comment.
Ah right I promised you that emoji guide, I'll do that in this PR. I like that the un-exported items are grouped together in a section that is color coded by a red emoji 😅 (and conveniently it's the sign for "secret" yeah). I can also append the word secret after the emoji? 🤷
There was a problem hiding this comment.
haha no worries, yeah I think just including the word Secret next to the emoji would be helpful, rather than having an emoji guide to refer to. I'm open to anything though. Whatever the most clear solution is for outside developers to tell what the section refers to 👍🏼
There was a problem hiding this comment.
Oh wait I did already add this, it's in src/README.md. It doesn't have an index table though, I'll add that.
|
Thanks @matheus23! I was waiting for the new release for the |
icidasset
force-pushed
the
icidasset/update-wnfs
branch
from
2352bc5
to
7450b91
Compare
Updates
wnfsto the latest version: Doesn't use name filters anymore,AccessKeyinstead ofPrivateRefand fixes a bug we had with older access keys.This PR also adds the UnixFS compatibility layer. Any time a mutation is made in the public file system, the change is reflect in the UnixFS node. This was added so that public content can be rendered on the IPFS gateway (eg. apps or images)
Other changes:
capsuleReftocapsuleKeyUint8Arrayinstead of an object with multiple.appPathfunction applicable to both public and private paths.Closes #546 and #547