Support terminal transparency by not setting window backgrounds #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop setting the background color of the tmux window. The effect of this change is to make tmux transparent in transparent terminals. One a properly set up terminal, this would have no other effect, as the background color of the terminal would be set correctly anyway.
This is a true fix for #5.
As examples: the window background color is not set in the following two tmux themes, both of which have good out-of-the-box transparent terminal support:
https://github.com/shaneog/tmux-colors-gotham
https://github.com/sei40kr/tmux-airline-dracula
I can change this to be toggled with an option, if you'd prefer that.