Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparently unneeded dependency on serde_with in atspi-macros #40

Closed
mwcampbell opened this issue Jan 2, 2023 · 2 comments
Closed

Apparently unneeded dependency on serde_with in atspi-macros #40

mwcampbell opened this issue Jan 2, 2023 · 2 comments

Comments

@mwcampbell
Copy link
Contributor

It looks like atspi-macros doesn't actually need the dependency on serde_with; it compiles fine without it. I bring this up because serde_with, at least using default features, adds many more dependencies, including such apparently nonsensical ones as android_system_properties (that one came indirectly via chrono). These may all be build-only, and some may be platform-specific dependencies that don't actually come up on any build platform, but some people will find the addition of so many extra dependencies in their Cargo.lock file annoying anyway.

luukvanderduim added a commit that referenced this issue Jan 2, 2023
This strips unnecessary dependencies as reported by @mwcampbell in #40
@luukvanderduim
Copy link
Collaborator

Thanks for bringing this to our attention.

We actually have a few more that cargo-udeps considers unused:

unused dependencies:
`atspi-macros v0.1.2 (/atspi-macros)`
└─── dependencies
     ├─── "prettyplease"
     ├─── "serde-xml-rs"
     └─── "zbus_xmlgen"

@TTWNO Can I safely merge the branch that removes the unused deps?

Thanks!

@TTWNO
Copy link
Member

TTWNO commented Jan 3, 2023

Sorry, I didn't even mean to publish that code to crates.io, I'm not sure how I ended up doing that.

Should be good now.

@TTWNO TTWNO closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants