Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Function Signature of proc CmdSetBlendConstants in vendor:vulkan #3799

Closed
tadeohepperle opened this issue Jun 23, 2024 · 1 comment · Fixed by #3813
Closed

Invalid Function Signature of proc CmdSetBlendConstants in vendor:vulkan #3799

tadeohepperle opened this issue Jun 23, 2024 · 1 comment · Fixed by #3813

Comments

@tadeohepperle
Copy link
Contributor

Context

Odin Version and OS:

    Odin:    dev-2024-06:f1779c85d
    OS:      Manjaro Linux, Linux 6.1.80-1-MANJARO
    CPU:     12th Gen Intel(R) Core(TM) i7-1260P
    RAM:     31806 MiB
    Backend: LLVM 14.0.6

Current & Expected Behavior

vulkan_core.h specifies:

typedef void (VKAPI_PTR *PFN_vkCmdSetBlendConstants)(VkCommandBuffer commandBuffer, const float blendConstants[4]);

but in vendor/vulkan/procedures.odin the function signature is:

ProcCmdSetBlendConstants :: #type proc "system" (commandBuffer: CommandBuffer)

This is wrong and currently makes it not possible to dynamically set blend constants in a vulkan application. I think the signature in odin should be

ProcCmdSetBlendConstants :: #type proc "system" (commandBuffer: CommandBuffer, blendConstants: [4]f32)
@tadeohepperle
Copy link
Contributor Author

Created a PR to fix it, not sure if other Vulkan functions also have similar problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant