Add posibility to turn off color bar in 2d plot

[aringh]

Example on how #1342 could be implemented. I found no tests for odl.util.graphics, but a minimal working example that shows how it works is given by

import odl
space = odl.uniform_discr([0,0], [1,1], [256,256])
x = odl.util.noise_element(space)
x.show()
x.show(show_2d_color_bar=False)

which gives the following images

Is this desirable? Or is it only adding unnecessary complexity to plotting?

[aringh]

They fail is due to doc build fail. This is observed also in (at least) #1321 and #1340

[adler-j]

I like it overall, but perhaps we should change the name of there parameter?

Something like show_colorbar or simply colorbar?

[adler-j]

And indeed something is up with the build server. Perhaps a Sphinx issue. Do you have any idea @kohr-h?

[kohr-h]

There's been an update do travis-sphinx on PyPI which seems to have broken things. Need to test it locally with more output.

[kohr-h]

Remove the "<1.7" part from the Sphinx install command, then everything should be fine. The new version of travis-sphinx doesn't work with Sphinx 1.6.x, possibly due to a patch by me 🙄

[kohr-h]

Remove the "<1.7" part from the Sphinx install command, then everything should be fine. The new version of travis-sphinx doesn't work with Sphinx 1.6.x, possibly due to a patch by me roll_eyes

After rebasing, the error should be fixed.

[kohr-h]

Something like show_colorbar or simply colorbar?

Definitely colorbar, since that allows us to later enable other types than bool, for example an instance of Colorbar or a string, if we ever decide to implement such a thing.

That said, feature creep is a real issue here. I'd say yes to changes that are very simple to implement with an additional flag in an if ... statement, but be cautious with changes that require more code. After all, this method is just a quick 'n dirty plotter, although I realize that lots of projects have these tools: started as a quick hack and became the most heavily used tool.

[aringh]

Changed the name and rebased. I will leave the PR hanging a little longer if @adler-j or @kohr-h have any final comments. Otherwise I will merge it sometime early next week.

[kohr-h]

2 quick comments:

• ``method`` 'imshow' -> ``method='imshow'``
• "If" can't start a main clause, I guess "Whether" would be more correct. But generally, explanations like "If ``True``, include a colorbar in the plot." are preferred.

[aringh]

Great! I will merge after the tests