Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 334 derivative #338

Merged
merged 5 commits into from
Apr 8, 2016
Merged

Issue 334 derivative #338

merged 5 commits into from
Apr 8, 2016

Conversation

adler-j
Copy link
Member

@adler-j adler-j commented Apr 5, 2016

Can return a finite set of examples or an infinite set.

Optional to implement, intended to be used for diagnostics.
Default yields ``('element()', self.element())``."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

""" on wrong line

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"By default, the generator yields ..."

@kohr-h
Copy link
Member

kohr-h commented Apr 6, 2016

Looking good in general. Just some minor remarks.

@adler-j
Copy link
Member Author

adler-j commented Apr 7, 2016

Fixed most comments, two bigger style changes

  • np.array([1.0]) is no longer a valid input array, it caused several bugs (it was cast to a scalar, which threw an error). It should likely be interpreted as a scalar.
  • Moved discretization examples to fspace, now simply discretizes the uspace examples.

Also minor style, for example update the examples file.

@kohr-h
Copy link
Member

kohr-h commented Apr 8, 2016

Good to go

@adler-j adler-j merged commit 6ba4348 into master Apr 8, 2016
@adler-j adler-j deleted the issue-334__derivative branch April 8, 2016 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derivative test needs some rethinking A better way of generating samples from a set
2 participants