BUG: fix corner case bugs in power_method_opnorm #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return sqrt(x.norm()) | ||
| x_norm = x.norm() | ||
| if x_norm == 0: | ||
| raise ValueError('reached ``x=0``') |
There was a problem hiding this comment.
Out of curiosity: when does this occur?
There was a problem hiding this comment.
There is an test for exactly this further down. Basically when you have an matrix like
[[0, 1],
[0, 0]]
and if you start with [1, 1], you then get [1, 0], and then [0, 0].
There was a problem hiding this comment.
Some reading material here
adler-j
force-pushed
the
fix_powermethod_opnorm_bug
branch
from
94d8c9f
to
6e39a28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some inconsistencies as reported by @niinimaki.