Skip to content

Commit

Permalink
[FIX] website_slides: load animations after slide loaded
Browse files Browse the repository at this point in the history
Issue: When using the Fullscreen mode of slides for articles we do run
first the website animations before loading the slide, which will make
the content to stay invisible since we will never actually perform the
animation.

Steps to reproduce:

1. Create a new course with an article content.
2. Add any block (text, image).
3. Add an animation to this piece of block.
4. Go to Fullscreen mode.

Solution:

We manually instantiate and attach the WebsiteAnimate widget to
the wpContainer element to ensure animations are properly initialized
and applied after the slide has loaded, after that we get rid of this
instance after every new slide that load so we avoid having multiple
instances.

opw-3757919

closes odoo#159032

X-original-commit: f9f53e3
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
  • Loading branch information
Ephoniz authored and awa-odoo committed Mar 27, 2024
1 parent 360881c commit 593ca1f
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,10 @@
var slide = this.get('slide');
var $content = this.$('.o_wslides_fs_content');
$content.empty();
if (this.websiteAnimateWidget) {
this.websiteAnimateWidget.destroy()
this.websiteAnimateWidget = null;
}

// display quiz slide, or quiz attached to a slide
if (slide.category === 'quiz' || slide.isQuiz) {
Expand All @@ -684,12 +688,14 @@
} else if (slide.category === 'video' && slide.videoSourceType === 'google_drive') {
$content.html(QWeb.render('website.slides.fullscreen.video.google_drive', {widget: this}));
} else if (slide.category === 'article'){
this.websiteAnimateWidget = new publicWidget.registry.WebsiteAnimate();
var $wpContainer = $('<div>').addClass('o_wslide_fs_article_content bg-white block w-100 overflow-auto p-3');
$wpContainer.html(slide.htmlContent);
$content.append($wpContainer);
this.trigger_up('widgets_start_request', {
$target: $content,
});
this.websiteAnimateWidget.attachTo($wpContainer);
}
unhideConditionalElements();
} finally {
Expand Down

0 comments on commit 593ca1f

Please sign in to comment.