-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add iframe support #2911
add iframe support #2911
Conversation
02de40c
to
afda3b9
Compare
This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged. |
c9d918c
to
2731fd4
Compare
onMounted(() => { | ||
let el = this.ref.el; | ||
if (this.props.inIFrame) { | ||
var html = `<div>${this.props.content || ""}</div>`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var
?? 😨
@@ -25,7 +25,7 @@ export class ToolbarPlugin extends Plugin { | |||
switch (command) { | |||
case "CONTENT_UPDATED": | |||
if (this.overlay.isOpen) { | |||
const range = getSelection().getRangeAt(0); | |||
const range = this.document.getSelection().getRangeAt(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getEditableSelection
@@ -36,7 +36,7 @@ export class PowerboxPlugin extends Plugin { | |||
} | |||
|
|||
openPowerbox() { | |||
const selection = window.getSelection(); | |||
const selection = this.document.getSelection(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getEditableSelection
f1b7d27
to
1b344e9
Compare
1b344e9
to
ab58447
Compare
No description provided.