Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iframe support #2911

Merged
merged 1 commit into from
Feb 13, 2024
Merged

add iframe support #2911

merged 1 commit into from
Feb 13, 2024

Conversation

ged-odoo
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Feb 13, 2024

This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged.

@ged-odoo ged-odoo force-pushed the master-phoenix-ged branch 4 times, most recently from c9d918c to 2731fd4 Compare February 13, 2024 09:46
onMounted(() => {
let el = this.ref.el;
if (this.props.inIFrame) {
var html = `<div>${this.props.content || ""}</div>`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var ?? 😨

@@ -25,7 +25,7 @@ export class ToolbarPlugin extends Plugin {
switch (command) {
case "CONTENT_UPDATED":
if (this.overlay.isOpen) {
const range = getSelection().getRangeAt(0);
const range = this.document.getSelection().getRangeAt(0);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getEditableSelection

@@ -36,7 +36,7 @@ export class PowerboxPlugin extends Plugin {
}

openPowerbox() {
const selection = window.getSelection();
const selection = this.document.getSelection();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getEditableSelection

@ged-odoo ged-odoo force-pushed the master-phoenix-ged branch 2 times, most recently from f1b7d27 to 1b344e9 Compare February 13, 2024 10:17
@cammarosano cammarosano merged commit 43da2c5 into master-phoenix Feb 13, 2024
@cammarosano cammarosano deleted the master-phoenix-ged branch February 13, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants