Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master phoenix fge 2 #2942

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Master phoenix fge 2 #2942

merged 3 commits into from
Feb 28, 2024

Conversation

FrancoisGe
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Feb 27, 2024

This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged.

const selection = this.shared.getEditableSelection();
// TODO @phoenix to discuss what we should do when we add a element ? Best practice ? (remove <br)
selection.anchorNode.prepend(element);
this.shared.setCursorEnd(selection.anchorNode);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to this.dispatch("ADD_STEP")

@cammarosano cammarosano merged commit c24cd71 into master-phoenix Feb 28, 2024
@cammarosano cammarosano deleted the master-phoenix-fge-2 branch February 28, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants