-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master phoenix fge 2 #2958
Merged
Merged
Master phoenix fge 2 #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged. |
Goaman
reviewed
Mar 7, 2024
Goaman
reviewed
Mar 7, 2024
|
||
export function normalizeCursorPosition(node, offset, right) { | ||
[node, offset] = normalizeSelfClosingElement(node, offset); | ||
[node, offset] = normalizeNotEditableNode(node, offset, right); | ||
// Be permissive about the received offset. | ||
offset = Math.min(Math.max(offset, 0), nodeSize(node)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goaman
reviewed
Mar 7, 2024
@@ -134,7 +138,7 @@ export class SelectionPlugin extends Plugin { | |||
* @param { Node } [selection.focusNode=selection.anchorNode] | |||
* @param { number } [selection.focusOffset=selection.anchorOffset] | |||
* @param { Object } [options] | |||
* @param { boolean } [normalize=true] Normalize the selection | |||
* @param { boolean } [normalize=true] Deep Normalize the selection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normalizeDeep=true
FrancoisGe
force-pushed
the
master-phoenix-fge-2
branch
2 times, most recently
from
March 8, 2024 08:48
8003c30
to
a9a6958
Compare
ged-odoo
force-pushed
the
master-phoenix
branch
from
March 11, 2024 13:08
6afc8bf
to
4553c64
Compare
FrancoisGe
force-pushed
the
master-phoenix-fge-2
branch
from
March 11, 2024 16:24
a9a6958
to
b4722b5
Compare
FrancoisGe
force-pushed
the
master-phoenix-fge-2
branch
from
March 12, 2024 08:04
b4722b5
to
e9446d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.