FIX/Spec change: tab on table #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged. |
ged-odoo
reviewed
Mar 12, 2024
cammarosano
force-pushed
the
master-phoenix-rcdl
branch
from
bb0ac99
to
6f39658
Compare
cammarosano
commented
Mar 12, 2024
| const { el } = await setupEditor(contentBefore); | ||
| press("Tab"); | ||
| expect(getContent(el)).toBe(contentAfter); | ||
| await animationFrame(); |
There was a problem hiding this comment.
Not the greatest way to test it, as the toolbar could still not be open after one animation frame...
But at least this will not fail undeterministically.
The test below is a better test for toolbar close.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See odoo@9361133