Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skeleton of the link plugin #2982

Merged
merged 2 commits into from Mar 18, 2024
Merged

Add skeleton of the link plugin #2982

merged 2 commits into from Mar 18, 2024

Conversation

Jinjiu96
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Mar 15, 2024

This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged.

@Jinjiu96 Jinjiu96 force-pushed the master-phoenix-jili branch 2 times, most recently from d2cbee2 to 2fc8835 Compare March 15, 2024 14:06
@Jinjiu96 Jinjiu96 marked this pull request as ready for review March 15, 2024 14:27
@robodoo
Copy link

robodoo commented Mar 15, 2024

This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged.

ged-odoo
ged-odoo reviewed Mar 15, 2024
View reviewed changes
addons/html_editor/static/src/editor/utils/selection.js Outdated
@@ -451,3 +451,19 @@ export function preserveCursor(document) {
return setSelection(...cursorPos, false);
};
}

export function getInSelection(document, selector) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we have a similar utility somewhere, but i am not sure

@Jinjiu96 Jinjiu96 marked this pull request as draft March 15, 2024 16:03
@robodoo
Copy link

robodoo commented Mar 15, 2024

This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged.

@Jinjiu96 Jinjiu96 force-pushed the master-phoenix-jili branch 2 times, most recently from a3106d2 to 77343be Compare March 18, 2024 10:36
@Jinjiu96 Jinjiu96 marked this pull request as ready for review March 18, 2024 12:57
@robodoo
Copy link

robodoo commented Mar 18, 2024

This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged.

@Jinjiu96 Jinjiu96 marked this pull request as draft March 18, 2024 13:22
@robodoo
Copy link

robodoo commented Mar 18, 2024

This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged.

@Jinjiu96 Jinjiu96 marked this pull request as ready for review March 18, 2024 13:37
@robodoo
Copy link

robodoo commented Mar 18, 2024

This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged.

@ged-odoo ged-odoo merged commit e559c0d into master-phoenix Mar 18, 2024
@ged-odoo ged-odoo deleted the master-phoenix-jili branch March 18, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ged-odoo ged-odoo ged-odoo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Jinjiu96 @robodoo @ged-odoo