Master phoenix rcdl 2 #3011
Merged
Master phoenix rcdl 2 #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged. |
ged-odoo
reviewed
Mar 26, 2024
| // Helpers for normalize | ||
| // -------------------------------------------------------------------------- | ||
|
|
||
| preserveSelection() { |
There was a problem hiding this comment.
looks like this should be in selection plugin?
There was a problem hiding this comment.
Probably.
But this is rather incomplete and only handles the use cases of list normalization so far...
There was a problem hiding this comment.
it's fine to have incomplete implementation imo. and it's better to put code at the proper location, so there is a higher chance that someone finds it (and improve it if necessary) later
Goaman
reviewed
Mar 26, 2024
| @@ -105,3 +79,19 @@ export function applyToTree(root, func) { | |||
| } | |||
| return modifiedRoot; | |||
| } | |||
|
|
|||
| // For now, only a few cases are handled. | |||
| export function preservePos(node, offset) { | |||
cammarosano
force-pushed
the
master-phoenix-rcdl-2
branch
from
728225b
to
4c84b1b
Compare
cammarosano
force-pushed
the
master-phoenix-rcdl-2
branch
from
4c84b1b
to
749bca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.