remove check in closestElement #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged. |
FrancoisGe
reviewed
Apr 22, 2024
| @@ -632,7 +632,7 @@ export class ListPlugin extends Plugin { | |||
| return; | |||
| } | |||
| // Detect if cursor is at beginning of LI. | |||
| if (closestElement(startContainer, "LI") !== closestLIendContainer) { | |||
| if (!startContainer || closestElement(startContainer, "LI") !== closestLIendContainer) { | |||
There was a problem hiding this comment.
What is the use case ? (test name ?)
There was a problem hiding this comment.
"@html_editor/list/delete_backward/selection collapsed/ordered/basic/should convert to paragraph"
There was a problem hiding this comment.
We should receive a range but startContainer is null. It look strange
There was a problem hiding this comment.
it's when there is no valid previous cursor position. so deletebackward should basically remove the list
ged-odoo
force-pushed
the
master-phoenix-ged
branch
2 times, most recently
from
a1370c4
to
6980b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.