Services dynamically add their component if they have one in the relevant registry #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kebeclibre
force-pushed
the
master-wowl-service-their-comps-lpe
branch
3 times, most recently
from
c889209
to
bc2915a
Compare
ged-odoo
reviewed
Jun 7, 2021
|
|
||
| const { EventBus } = owl.core; | ||
|
|
||
| export const popoverService = { | ||
| start() { | ||
| let nextId = 0; | ||
| /** |
kebeclibre
force-pushed
the
master-wowl-service-their-comps-lpe
branch
3 times, most recently
from
5685a95
to
544c6c3
Compare
kebeclibre
force-pushed
the
master-wowl-service-their-comps-lpe
branch
7 times, most recently
from
dfc5f12
to
8ae952b
Compare
|
robodoo rebase-ff r+ |
|
Merge method set to rebase and fast-forward |
kebeclibre
force-pushed
the
master-wowl-service-their-comps-lpe
branch
5 times, most recently
from
ee7ad7e
to
39c1faa
Compare
ged-odoo
reviewed
Jun 11, 2021
| @@ -1,22 +1,18 @@ | |||
| /** @odoo-module **/ | |||
|
|
|||
| import { registry } from "../registry"; | |||
| import { useService } from "../service_hook"; | |||
| import { Notification as NotificationComponent } from "./notification"; | |||
|
robodoo r+ |
|
Unable to stage PR ({"message":"Merge conflict","documentation_url":"https://docs.github.com/rest/reference/repos#merge-a-branch"}) |
Some services are coupled with a Component. Usually the service handles the state of the system, and the Component displays or uses it. To enable the communication between the service and the component while making it private, the services should add themselves their Component in the relevant registry, with the proper means of communication passed in props. This mechanism relies on c1d49d4
ged-odoo
force-pushed
the
master-wowl-service-their-comps-lpe
branch
from
39c1faa
to
46b3576
Compare
|
robodoo retry r+ |
|
I'm sorry, @ged-odoo. Retry makes no sense when the PR is not in error. |
aab-odoo
pushed a commit
that referenced
this pull request
Jun 14, 2021
closes #925 Related: odoo-dev/enterprise#166 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 15, 2021
closes #925 Related: odoo-dev/enterprise#166 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 15, 2021
closes #925 Related: odoo-dev/enterprise#166 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 16, 2021
closes #925 Related: odoo-dev/enterprise#166 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 16, 2021
closes #925 Related: odoo-dev/enterprise#166 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 17, 2021
closes #925 Related: odoo-dev/enterprise#166 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 17, 2021
closes #925 Related: odoo-dev/enterprise#166 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
closes #925 Related: odoo-dev/enterprise#166 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
closes #925 Related: odoo-dev/enterprise#166 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
closes #925 Related: odoo-dev/enterprise#166 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.