[IMP] web: tests setup: check integrity of legacy global objects #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kebeclibre
force-pushed
the
master-wowl-global-pollution-lpe
branch
from
1ef13ba
to
b534cd7
Compare
ged-odoo
reviewed
Jun 10, 2021
kebeclibre
force-pushed
the
master-wowl-global-pollution-lpe
branch
from
b534cd7
to
f9e5590
Compare
Legacy tests and business code heavily use some global objects (session and _t) Wowl tests are set to clean the execution environment at the end of each tests while legacy tests clean their environment when the widget is destroyed This discrepancy may introduce weird, untimely and virtually undebuggable issues for the average Joe, because some tests may pollute the execution environment for following tests This commit aims at limiting this risk by hardcoding a few objects and their field to be checked at the end of each test
kebeclibre
force-pushed
the
master-wowl-global-pollution-lpe
branch
from
f9e5590
to
5a09ab7
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jun 10, 2021
Legacy tests and business code heavily use some global objects (session and _t) Wowl tests are set to clean the execution environment at the end of each tests while legacy tests clean their environment when the widget is destroyed This discrepancy may introduce weird, untimely and virtually undebuggable issues for the average Joe, because some tests may pollute the execution environment for following tests This commit aims at limiting this risk by hardcoding a few objects and their field to be checked at the end of each test closes #945 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 14, 2021
Legacy tests and business code heavily use some global objects (session and _t) Wowl tests are set to clean the execution environment at the end of each tests while legacy tests clean their environment when the widget is destroyed This discrepancy may introduce weird, untimely and virtually undebuggable issues for the average Joe, because some tests may pollute the execution environment for following tests This commit aims at limiting this risk by hardcoding a few objects and their field to be checked at the end of each test closes #945 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 15, 2021
Legacy tests and business code heavily use some global objects (session and _t) Wowl tests are set to clean the execution environment at the end of each tests while legacy tests clean their environment when the widget is destroyed This discrepancy may introduce weird, untimely and virtually undebuggable issues for the average Joe, because some tests may pollute the execution environment for following tests This commit aims at limiting this risk by hardcoding a few objects and their field to be checked at the end of each test closes #945 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 15, 2021
Legacy tests and business code heavily use some global objects (session and _t) Wowl tests are set to clean the execution environment at the end of each tests while legacy tests clean their environment when the widget is destroyed This discrepancy may introduce weird, untimely and virtually undebuggable issues for the average Joe, because some tests may pollute the execution environment for following tests This commit aims at limiting this risk by hardcoding a few objects and their field to be checked at the end of each test closes #945 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 16, 2021
Legacy tests and business code heavily use some global objects (session and _t) Wowl tests are set to clean the execution environment at the end of each tests while legacy tests clean their environment when the widget is destroyed This discrepancy may introduce weird, untimely and virtually undebuggable issues for the average Joe, because some tests may pollute the execution environment for following tests This commit aims at limiting this risk by hardcoding a few objects and their field to be checked at the end of each test closes #945 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 16, 2021
Legacy tests and business code heavily use some global objects (session and _t) Wowl tests are set to clean the execution environment at the end of each tests while legacy tests clean their environment when the widget is destroyed This discrepancy may introduce weird, untimely and virtually undebuggable issues for the average Joe, because some tests may pollute the execution environment for following tests This commit aims at limiting this risk by hardcoding a few objects and their field to be checked at the end of each test closes #945 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 17, 2021
Legacy tests and business code heavily use some global objects (session and _t) Wowl tests are set to clean the execution environment at the end of each tests while legacy tests clean their environment when the widget is destroyed This discrepancy may introduce weird, untimely and virtually undebuggable issues for the average Joe, because some tests may pollute the execution environment for following tests This commit aims at limiting this risk by hardcoding a few objects and their field to be checked at the end of each test closes #945 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 17, 2021
Legacy tests and business code heavily use some global objects (session and _t) Wowl tests are set to clean the execution environment at the end of each tests while legacy tests clean their environment when the widget is destroyed This discrepancy may introduce weird, untimely and virtually undebuggable issues for the average Joe, because some tests may pollute the execution environment for following tests This commit aims at limiting this risk by hardcoding a few objects and their field to be checked at the end of each test closes #945 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
Legacy tests and business code heavily use some global objects (session and _t) Wowl tests are set to clean the execution environment at the end of each tests while legacy tests clean their environment when the widget is destroyed This discrepancy may introduce weird, untimely and virtually undebuggable issues for the average Joe, because some tests may pollute the execution environment for following tests This commit aims at limiting this risk by hardcoding a few objects and their field to be checked at the end of each test closes #945 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
Legacy tests and business code heavily use some global objects (session and _t) Wowl tests are set to clean the execution environment at the end of each tests while legacy tests clean their environment when the widget is destroyed This discrepancy may introduce weird, untimely and virtually undebuggable issues for the average Joe, because some tests may pollute the execution environment for following tests This commit aims at limiting this risk by hardcoding a few objects and their field to be checked at the end of each test closes #945 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
Legacy tests and business code heavily use some global objects (session and _t) Wowl tests are set to clean the execution environment at the end of each tests while legacy tests clean their environment when the widget is destroyed This discrepancy may introduce weird, untimely and virtually undebuggable issues for the average Joe, because some tests may pollute the execution environment for following tests This commit aims at limiting this risk by hardcoding a few objects and their field to be checked at the end of each test closes #945 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy tests and business code heavily use some global objects (session and _t)
Wowl tests are set to clean the execution environment at the end of each tests
while legacy tests clean their environment when the widget is destroyed
This discrepancy may introduce weird, untimely and virtually undebuggable issues
for the average Joe, because some tests may pollute the execution environment for following tests
This commit aims at limiting this risk by hardcoding a few objects and their field to be checked at the end of each test