Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] web: remove the Portal from dialog #947

Closed
wants to merge 1 commit into from
Closed

[IMP] web: remove the Portal from dialog #947

wants to merge 1 commit into from

Conversation

jpp-odoo
Copy link

@jpp-odoo jpp-odoo commented Jun 10, 2021 •
edited

In this commit, we simplify the dialog template by removing the Portal.
The Portal is no longer used, as now we always use the dialog service to
open a new dialog.

also:

  • remove the dialog container class from the webclient;
  • add the dialog container class to the dialog container;
  • move the management of the inactive modal class to the dialog container;
  • remove the dialog manager class from the dialog container;

@robodoo
Copy link

robodoo commented Jun 10, 2021

Pull request status dashboard.

@jpp-odoo jpp-odoo force-pushed the master-wowl-delete_portal_dialog-jpp branch 4 times, most recently from 29eb546 to fa20156 Compare June 11, 2021 09:24
@jpp-odoo jpp-odoo changed the title WIP [IMP] web: remove the Portal from dialog Jun 11, 2021
@jpp-odoo jpp-odoo force-pushed the master-wowl-delete_portal_dialog-jpp branch 2 times, most recently from 47d7c75 to f41d017 Compare June 14, 2021 07:45
@jpp-odoo jpp-odoo marked this pull request as ready for review June 14, 2021 07:45
@jpp-odoo jpp-odoo force-pushed the master-wowl-delete_portal_dialog-jpp branch 3 times, most recently from 246eac8 to 7bdd48d Compare June 14, 2021 08:11
@jpp-odoo
[IMP] web: remove the Portal from dialog
1767690 
In this commit, we simplify the dialog template by removing the Portal.
The Portal is no longer used, as now we always use the dialog service to
open a new dialog.

also:

- remove the dialog container class from the webclient;
- add the dialog container class to the dialog container;
- move the management of the inactive modal class to the dialog container;
- remove the dialog manager class from the dialog container;
@jpp-odoo jpp-odoo force-pushed the master-wowl-delete_portal_dialog-jpp branch from 7bdd48d to 1767690 Compare June 14, 2021 08:35
@ged-odoo
Copy link

robodoo r+

robodoo pushed a commit that referenced this pull request Jun 14, 2021
@jpp-odoo
[IMP] web: remove the Portal from dialog
054dad0 
In this commit, we simplify the dialog template by removing the Portal.
The Portal is no longer used, as now we always use the dialog service to
open a new dialog.

also:

- remove the dialog container class from the webclient;
- add the dialog container class to the dialog container;
- move the management of the inactive modal class to the dialog container;
- remove the dialog manager class from the dialog container;

closes #947

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
@robodoo robodoo closed this Jun 14, 2021
@jpp-odoo jpp-odoo deleted the master-wowl-delete_portal_dialog-jpp branch June 14, 2021 11:37
aab-odoo pushed a commit that referenced this pull request Jun 15, 2021
@jpp-odoo @aab-odoo
[IMP] web: remove the Portal from dialog
159af85 
In this commit, we simplify the dialog template by removing the Portal.
The Portal is no longer used, as now we always use the dialog service to
open a new dialog.

also:

- remove the dialog container class from the webclient;
- add the dialog container class to the dialog container;
- move the management of the inactive modal class to the dialog container;
- remove the dialog manager class from the dialog container;

closes #947

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo pushed a commit that referenced this pull request Jun 15, 2021
@jpp-odoo @aab-odoo
[IMP] web: remove the Portal from dialog
45164c2 
In this commit, we simplify the dialog template by removing the Portal.
The Portal is no longer used, as now we always use the dialog service to
open a new dialog.

also:

- remove the dialog container class from the webclient;
- add the dialog container class to the dialog container;
- move the management of the inactive modal class to the dialog container;
- remove the dialog manager class from the dialog container;

closes #947

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo pushed a commit that referenced this pull request Jun 16, 2021
@jpp-odoo @aab-odoo
[IMP] web: remove the Portal from dialog
c093145 
In this commit, we simplify the dialog template by removing the Portal.
The Portal is no longer used, as now we always use the dialog service to
open a new dialog.

also:

- remove the dialog container class from the webclient;
- add the dialog container class to the dialog container;
- move the management of the inactive modal class to the dialog container;
- remove the dialog manager class from the dialog container;

closes #947

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo pushed a commit that referenced this pull request Jun 16, 2021
@jpp-odoo @aab-odoo
[IMP] web: remove the Portal from dialog
faed9e1 
In this commit, we simplify the dialog template by removing the Portal.
The Portal is no longer used, as now we always use the dialog service to
open a new dialog.

also:

- remove the dialog container class from the webclient;
- add the dialog container class to the dialog container;
- move the management of the inactive modal class to the dialog container;
- remove the dialog manager class from the dialog container;

closes #947

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo pushed a commit that referenced this pull request Jun 17, 2021
@jpp-odoo @aab-odoo
[IMP] web: remove the Portal from dialog
757d71b 
In this commit, we simplify the dialog template by removing the Portal.
The Portal is no longer used, as now we always use the dialog service to
open a new dialog.

also:

- remove the dialog container class from the webclient;
- add the dialog container class to the dialog container;
- move the management of the inactive modal class to the dialog container;
- remove the dialog manager class from the dialog container;

closes #947

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo pushed a commit that referenced this pull request Jun 17, 2021
@jpp-odoo @aab-odoo
[IMP] web: remove the Portal from dialog
b76440f 
In this commit, we simplify the dialog template by removing the Portal.
The Portal is no longer used, as now we always use the dialog service to
open a new dialog.

also:

- remove the dialog container class from the webclient;
- add the dialog container class to the dialog container;
- move the management of the inactive modal class to the dialog container;
- remove the dialog manager class from the dialog container;

closes #947

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo pushed a commit that referenced this pull request Jun 18, 2021
@jpp-odoo @aab-odoo
[IMP] web: remove the Portal from dialog
81b6bcd 
In this commit, we simplify the dialog template by removing the Portal.
The Portal is no longer used, as now we always use the dialog service to
open a new dialog.

also:

- remove the dialog container class from the webclient;
- add the dialog container class to the dialog container;
- move the management of the inactive modal class to the dialog container;
- remove the dialog manager class from the dialog container;

closes #947

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo pushed a commit that referenced this pull request Jun 18, 2021
@jpp-odoo @aab-odoo
[IMP] web: remove the Portal from dialog
88d8c5d 
In this commit, we simplify the dialog template by removing the Portal.
The Portal is no longer used, as now we always use the dialog service to
open a new dialog.

also:

- remove the dialog container class from the webclient;
- add the dialog container class to the dialog container;
- move the management of the inactive modal class to the dialog container;
- remove the dialog manager class from the dialog container;

closes #947

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo pushed a commit that referenced this pull request Jun 18, 2021
@jpp-odoo @aab-odoo
[IMP] web: remove the Portal from dialog
85dfc9c 
In this commit, we simplify the dialog template by removing the Portal.
The Portal is no longer used, as now we always use the dialog service to
open a new dialog.

also:

- remove the dialog container class from the webclient;
- add the dialog container class to the dialog container;
- move the management of the inactive modal class to the dialog container;
- remove the dialog manager class from the dialog container;

closes #947

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jpp-odoo @robodoo @ged-odoo