master wowl design sri ges #949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop `o_dropdown_toggler_btn` class in favor of `o_dropdown_toggler`. o_dropdown_toggler_btn was initially introduced in ~13.3, but it's now obsolete.
By default we add a chevron icon before active dropdown menu entries. In some circumstances it may be misleading, for example when the entry is not a real option but just toggle for other elements visibility (eg. control_panel's custom filters). This commit introduces a new class that, in conjunction with the '.active' one, will remove the icon while keeping others style rules untouched.
Overall colors review to achieve WACG standard compliance. https://www.w3.org/WAI/standards-guidelines/wcag/ Current contextual colors work fine when used for backgrounds but fail WACG tests when are used for text. Unfortunately Bootstrap use the same palette in both scenarios without providing effective control over text colors. The 'text-emphasis-variant' mixin, indeed, allows to darken a color by a certain amount, but since the amount is not customizable per-color the final result is always either too dark or too light for colors that are not used as a reference. This commit will define a specif SCSS map called `$o-theme-text-colors` that mirrors the default '$theme-colors' structure and contain fine-tuned values to be used specifically for text. In order to keep the same classes names, we customize the default 'text-emphasis-variant' mixin, instructing it to first look for our fine-tuned colors and eventually fallback to default. This commit will also adapt all the modules that use to hardcode text colors in SCSS rather than using default utility classes. We handle this using different approaches: - Use utility classes whenever is possible (eg. 'text-info') - If apply the class directly is not possible, '@extend' it in SCSS - If '@extend' is not ideal because of code complexity (eg. ':hover' interactions), use the new 'o-text-color([color name])' scss function.
Prior to this commit web_editor custom rules were affecting the entire bundle.
Prior to this commit, legacy dropdown menus where not targeted correctly.
Adapt breadcrumb 'current' entry color according to its context. If other entries are visible and clickable, 'current' will be muted (default). If 'current' it's the only entry, then it acts as view's title and it will be styled more prominent.
Extend utility classes allowing to use 'sm' and 'lg' variations for directional border-radius utility classes (eg. 'rounded-lg-left'). The aim is to avoid inconsistencies for all these components that use custom border-radius values (eg. chatter composer).
This commit will applies several design improvements like alignment adjustments and better use of colors. It will also replace custom scss rules with utility classes whenever is possible. To take advantage of browsers' user agent stylesheets, some html tags will be replaced too. eg. from '<span.customCssForDisplayBlock/>' to '<div/>'
Prior to this commit these rules were affecting the entire view.
|
robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward |
|
Linked pull request(s) odoo-dev/enterprise#176 not ready. Linked PRs are not staged until all of them are ready. |
robodoo
pushed a commit
that referenced
this pull request
Jun 11, 2021
Prior to this commit these rules were affecting the entire view. closes #949 Related: odoo-dev/enterprise#176 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 14, 2021
Prior to this commit these rules were affecting the entire view. closes #949 Related: odoo-dev/enterprise#176 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 15, 2021
Prior to this commit these rules were affecting the entire view. closes #949 Related: odoo-dev/enterprise#176 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 15, 2021
Prior to this commit these rules were affecting the entire view. closes #949 Related: odoo-dev/enterprise#176 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 16, 2021
Prior to this commit these rules were affecting the entire view. closes #949 Related: odoo-dev/enterprise#176 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 16, 2021
Prior to this commit these rules were affecting the entire view. closes #949 Related: odoo-dev/enterprise#176 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 17, 2021
Prior to this commit these rules were affecting the entire view. closes #949 Related: odoo-dev/enterprise#176 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 17, 2021
Prior to this commit these rules were affecting the entire view. closes #949 Related: odoo-dev/enterprise#176 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
Prior to this commit these rules were affecting the entire view. closes #949 Related: odoo-dev/enterprise#176 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
Prior to this commit these rules were affecting the entire view. closes #949 Related: odoo-dev/enterprise#176 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
aab-odoo
pushed a commit
that referenced
this pull request
Jun 18, 2021
Prior to this commit these rules were affecting the entire view. closes #949 Related: odoo-dev/enterprise#176 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr