New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] localizations: Philippines (SLSP and 2550Q) #8145
Conversation
Hi @ralo-odoo! Replying because our team got automatically pinged. It seems you have a few build errors, if you want a review, you can ping us once they have been sorted out :) |
Hi @toaa-odoo Thanks for the feedback! I have fixed the small formatting issues! Let me know if there is any further issues with the content! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ralo-odoo ! Thanks for your great work. Unfortunately, I do not have the right to push myself on your fork, so instead I suggest you copy-paste the following text into the PR. It contains minor changes (such as commas, rephrasing of some sentences, formatting, etc.)
Two comments: 1) We usually use only one way of writing file format, that is either .xls (dot + small caps), or XLS (no dot + all caps). You can select whichever you prefer, but you have to be consistent throughout the page. I changed it for you in the C/C text :). 2) You currently have two commits, the bot will not know which ones has to be merged first, therefore you need to squash them first.
Cheers! 👍
===========
Philippines
Configuration
:ref:Install <general/install>
the :guilabel:🇵🇭 Philippines
:ref:fiscal localization package <fiscal_localizations/packages>
to get all the default accounting features of the Philippine
localization, such as a chart of accounts, taxes, and the BIR 2307 report. These provide a base
template to get started with using Philippine accounting.
.. note::
- When creating a new database and selecting the
Philippines
as a country, the fiscal
localization module Philippines - Accounting is automatically installed. - If the module is installed in an existing company, the chart of accounts and taxes will
not be replaced if there are already posted journal entries. - The BIR 2307 report is installed, but the withholding taxes may need to be manually created.
Chart of accounts and taxes
A minimum configuration default chart of accounts is installed, and the following types of taxes are
installed and linked to the relevant account:
- Sales and Purchase VAT 12%
- Sales and Purchase VAT Exempt
- Sales and Purchase VAT Zero-Rated
- Purchase Withholding
For the withholding taxes (:menuselection:Configuration --> Taxes
), there is an additional
:guilabel:Philippines ATC
field under the :guilabel:Philippines
tab.
.. image:: philippines/philippines-atc-code.png
:alt: Philippines ATC code field set on taxes.
.. note::
Taxes' ATC codes are used for the BIR 2307 report. If a tax is created manually, its ATC code
must be added.
Contacts
When a company or an individual (not belonging to a company) contact is located in the Philippines,
fill in the :guilabel:Tax ID
field with their Taxpayer Identification Number (TIN)
.
For individuals not belonging to a company, identify them by using the following additional fields:
- :guilabel:
First Name
- :guilabel:
Middle Name
- :guilabel:
Last Name
.. image:: philippines/philippines-contact-individual.png
:alt: Individual type contact with First, Middle, and Last Name fields.
.. note::
For both :guilabel:Company
and :guilabel:Individual
, the TIN should follow the
NNN-NNN-NNN-NNNNN
format. The branch code should follow the last digits of the TIN, or else can
be left as 00000
.
BIR 2307 report
BIR 2307 report data, also known as Certificate of Creditable Tax Withheld at Source <https://www.bir.gov.ph/index.php/bir-forms/certificates.html>
_,
can be generated for purchase orders and vendor payments with the applicable withholding taxes.
To generate a BIR 2307 report, select one or multiple vendor bills from the list view, and click
:menuselection:Action --> Download BIR 2307 XLS
.
.. image:: philippines/philippines-multi-bill.png
:alt: Multiple vendor bills selected with action to "Download BIR 2307 XLS".
.. tip::
The same action can be performed on a vendor bill from the form view.
A pop-up appears to review the selection, then click on :guilabel:Generate
.
.. image:: philippines/philippines-generate.png
:alt: Pop up menu to generate BIR 2307 XLS file.
This generates the Form_2307.xls
file that lists all the vendor bill lines with the applicable
withholding tax.
The process above can also be used for a single vendor :doc:payment <../accounting/payments>
if
it is linked to one or more :doc:vendor bills <../accounting/payments>
with applied withholding
taxes.
.. note::
- If there is no withholding tax applied, then the XLS file will not generate records for
those vendor bill lines. - When grouping payments for multiple bills, Odoo splits the payments based on the contact.
From a payment, clicking :menuselection:Action --> Download BIR 2307 XLS
generates a report
that only includes vendor bills related to that contact.
.. important::
Odoo cannot generate the BIR 2307 PDF report or DAT files directly. The generated
:file:Form_2307.xls
file can be exported to an external tool to convert it to BIR DAT or PDF
format.
SLSP Report
The SLSP report also known as the Summary List of Sales and Purchases can be viewed and
exported (in XLSX format). The report can be viewed from
:menuselection:Reporting --> Partner Reports --> Summary List of Sales and Purchases
.
The report is split into two sections which can be accessed from their respective buttons at the
top:
- :guilabel:
Sales
for :abbr:SLS (Summary List of Sales)
report.
All customer invoices with the associated sales taxes applied are shown on this report. - :guilabel:
Purchases
for :abbr:SLP (Summary List of Purchases)
report.
All vendor bills with the associated purchase taxes applied care shown on this report.
.. image:: philippines/philippines-slsp.png
:alt: SLSP Report
By default, both reports will exclude journal entries containing partners without a TIN number set
and those with importation taxes set. To view or hide them, the :guilabel:Options:
button will
give additional filters to include these, among others:
Including Partners Without TIN
Including Importations
.. important::
Odoo cannot generate the DAT files directly.
The :guilabel:Export SLSP
and :guilabel:XLSX
buttons will export a XLSX file which can be
processed using a external tool to convert it to the DAT format.
2550Q Tax report
The tax report report is viewed in
:menuselection:Reporting --> Statement Reports --> Tax Report --> 2550Q(PH)
.
The form is based on the latest 2550Q (Quarterly Value-Added Tax Return) Jan. 2023 version.
.. image:: philippines/philippines-2550Q.png
:alt: 2550Q Tax Report
.. tip::
Most lines in the tax report are automatically computed based on the taxes. For more accurate
reporting and filing of the tax report, manual journal entries can also be mapped to the tax
report through preconfigured Tax Grids for each tax report line.
.. important::
Odoo cannot generate the 2550Q BIR formatted PDF report directly. It should be used as
reference when externally filing the form manually or online.
@toaa-odoo Thanks for the feedback! Unfortunately, I think the way the code was pasted a lot of the rst formatting is gone as github applied those as markdown formatting so I couldn't directly copy paste it. I think either can re comment as code OR can do what we did before for the other PR where can create a new fork. |
My bad, you should now be able to c/p the text. The commits still need to be squashed as to only have one of them :) |
@toaa-odoo thanks for that! I have made a new commit with your changes and tried to squash the commits but I am not sure if it worked as it now says there is 6 commits in the PR. Let me know if I should try again but apologies as I am not too familiar with git CLI commands. |
Hello, indeed the squash has not worked. I did the steps locally on my machine (but since I cannot push on your branch, you will have to do them). It should go something like this:
This should solve the issue, if you are having trouble let me know and I'll try to record a video for you :) |
84268b1
to
5a926fc
Compare
@toaa-odoo Thanks for your detailed explanation and steps! I encountered some issues along the way but I think I managed to rebase and squash then push! Let me know if there is any outstanding issues! |
998a0f4
to
a3172ff
Compare
@ralo-odoo Hi, @jcs-odoo is fixing the aforementioned squash issues. He'll merge it when it's ready :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I didn't send the review. I'll update the branch briefly with these suggestions and some minor changes. Cheers!
@@ -11,30 +11,32 @@ localization, such as a chart of accounts, taxes, and the BIR 2307 report. These | |||
template to get started with using Philippine accounting. | |||
|
|||
.. note:: | |||
- When creating a new database and `Philippines` is selected as a country, the fiscal | |||
- When creating a new database and selecting the `Philippines` as a country, the fiscal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this kind of improvement should normally be done for all applicable versions.
So it would be best to backport these changes to pre-17.0 versions to avoid discrepancies between versions (it also has an impact on the translations, as these strings wouldn't match anymore)
*not* be replaced if there are already posted journal entries. | ||
- The BIR 2307 report is installed, but the withholding taxes may need to be manually created. | ||
|
||
Chart of accounts and taxes | ||
--------------------------- | ||
|
||
A minimum configuration default chart of accounts is installed, and the following types of taxes are | ||
installed and also linked to the relevant account: | ||
installed and linked to the relevant account: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes aren't always worth breaking the translations, in my opinion; but it's an easy fix for the translators in this specific case.
- If there is no withholding tax applied, then the XLS file will not generate records for | ||
those vendor bill lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If there is no withholding tax applied, then the XLS file will not generate records for | |
those vendor bill lines. | |
- If no withholding tax is applied, then the XLS file will not generate records for those vendor | |
bill lines. |
- :guilabel:`Sales` for :abbr:`SLS (Summary List of Sales)` report. | ||
All customer invoices with the associated sales taxes applied are shown on this report. | ||
- :guilabel:`Purchases` for :abbr:`SLP (Summary List of Purchases)` report. | ||
All vendor bills with the associated purchase taxes applied care shown on this report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- :guilabel:`Sales` for :abbr:`SLS (Summary List of Sales)` report. | |
All customer invoices with the associated sales taxes applied are shown on this report. | |
- :guilabel:`Purchases` for :abbr:`SLP (Summary List of Purchases)` report. | |
All vendor bills with the associated purchase taxes applied care shown on this report. | |
- | :guilabel:`Sales` for :abbr:`SLS (Summary List of Sales)` report | |
| All customer invoices with the associated sales taxes applied are shown in this report. | |
- | :guilabel:`Purchases` for :abbr:`SLP (Summary List of Purchases)` report | |
| All vendor bills with the associated purchase taxes applied are shown in this report. |
Odoo cannot generate the 2550Q BIR formatted PDF report directly. It should be used as | ||
reference when externally filing the form manually or online. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odoo cannot generate the 2550Q BIR formatted PDF report directly. It should be used as | |
reference when externally filing the form manually or online. | |
Odoo cannot generate the 2550Q BIR formatted PDF report directly. It should be used as a | |
reference when externally filing the form manually or online. |
or PDF format. | ||
Odoo cannot generate the 2550Q BIR formatted PDF report directly. It should be used as | ||
reference when externally filing the form manually or online. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toaa-odoo It's mportant to have a blank line with no character (here there were some spaces ^^' ) to get a green build from ci/documentation_guidelines
See the build error message https://runbot.odoo.com/runbot/build/60378088
:menuselection:`Reporting --> Statement Reports --> Tax Report --> 2550Q(PH)`. | ||
The form is based on the latest *2550Q (Quarterly Value-Added Tax Return)* Jan. 2023 version. | ||
|
||
.. image:: philippines/philippines-2550Q.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for a shared prefix, we already have the folder name for that :)
.. image:: philippines/philippines-2550Q.png | |
.. image:: philippines/2550Q.png |
- :guilabel:`Purchases` for :abbr:`SLP (Summary List of Purchases)` report. | ||
All vendor bills with the associated purchase taxes applied care shown on this report. | ||
|
||
.. image:: philippines/philippines-slsp.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for a shared prefix, we already have the folder name for that :)
.. image:: philippines/philippines-slsp.png | |
.. image:: philippines/slsp.png |
.. important:: | ||
Odoo cannot generate the DAT files directly. | ||
The :guilabel:`Export SLSP` and :guilabel:`XLSX` buttons will export a XLSX file which can be | ||
processed using a *external* tool to convert it to the DAT format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. important:: | |
Odoo cannot generate the DAT files directly. | |
The :guilabel:`Export SLSP` and :guilabel:`XLSX` buttons will export a XLSX file which can be | |
processed using a *external* tool to convert it to the DAT format. | |
.. important:: | |
Odoo cannot generate the DAT files directly. The :guilabel:`Export SLSP` and :guilabel:`XLSX` | |
buttons export an XLSX file, which can be processed using an *external* tool to convert to the | |
DAT format. |
Added additonal sections for SLSP and 2550Q tax report as these were updated for 17.0
a3172ff
to
c4b4ccd
Compare
@robodoo r+ |
Added additonal sections for SLSP and 2550Q tax report as these were updated for 17.0 l10n_ph module