Skip to content

Conversation

@dade-odoo
Copy link
Contributor

@dade-odoo dade-odoo commented Jul 25, 2023

From PR #5179, commit f3179bd
and commit 7e92b08

task-3440889

@robodoo
Copy link
Collaborator

robodoo commented Jul 25, 2023

@C3POdoo C3POdoo requested a review from a team July 25, 2023 08:31
@dade-odoo dade-odoo force-pushed the 16.0-localization-philippines-dade branch from 963ec42 to 175e65f Compare July 25, 2023 11:13
@dade-odoo dade-odoo requested review from a team and removed request for a team July 26, 2023 07:56
@toaa-odoo toaa-odoo requested a review from a team July 26, 2023 09:10
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to disagree and or discuss my suggestions :)

@dade-odoo dade-odoo force-pushed the 16.0-localization-philippines-dade branch from 175e65f to 8ffdd93 Compare August 2, 2023 11:33
@dade-odoo
Copy link
Contributor Author

This is ready for another look @xpl-odoo :) Let me know what you think about keeping/removing the contact record screenshots and my use of the :menuselection: format for the action menu.

@dade-odoo dade-odoo force-pushed the 16.0-localization-philippines-dade branch from 8ffdd93 to 854cde0 Compare August 2, 2023 12:43
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine, just check that the content under the Contacts heading was updated how you wanted it to be :)

@robodoo delegate+

@dade-odoo dade-odoo force-pushed the 16.0-localization-philippines-dade branch from 854cde0 to e13f547 Compare August 7, 2023 10:37
@dade-odoo
Copy link
Contributor Author

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Aug 7, 2023

@dade-odoo because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward

Adding Philippines localization documentation from PR #5179
@dade-odoo dade-odoo force-pushed the 16.0-localization-philippines-dade branch from e13f547 to 10aa0c4 Compare August 7, 2023 11:47
@dade-odoo
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants