[FIX] packaging, adapt documentation #9116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavier-Do
force-pushed
the
15.0-noble-packaging-xdo
branch
from
ecd1ba9
to
17ccd34
Compare
Xavier-Do
force-pushed
the
15.0-noble-packaging-xdo
branch
from
17ccd34
to
b332392
Compare
|
robodoo r+ |
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
May 28, 2024
lxml.hml.clean was moved to a separate package starting in lxml 5.2 The requirements and debian control needs to be adapted to install the new package in ubuntu noble (and after ubuntu noble only) The solution was to use fallback to try to install lxml_html_clean if it exists (noble) and fallback on lxml if not. The script use in the documentation and available in more recent version will take all first packge of the debian conrtol, meaning that after this change it won't work in distribution not having lxml_html_clean. The script is adapted to use fallback in apt-install command Debian control: font1 | font2, package_1, package_noble | package_fallback, Before: apt install font1 package package_noble After: apt install font1|font2 package package_noble|package_fallback closes #163788 Related: odoo/documentation#9116 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 28, 2024
closes #9116 Related: odoo/odoo#163788 Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
May 28, 2024
lxml.hml.clean was moved to a separate package starting in lxml 5.2 The requirements and debian control needs to be adapted to install the new package in ubuntu noble (and after ubuntu noble only) The solution was to use fallback to try to install lxml_html_clean if it exists (noble) and fallback on lxml if not. The script use in the documentation and available in more recent version will take all first packge of the debian conrtol, meaning that after this change it won't work in distribution not having lxml_html_clean. The script is adapted to use fallback in apt-install command Debian control: font1 | font2, package_1, package_noble | package_fallback, Before: apt install font1 package package_noble After: apt install font1|font2 package package_noble|package_fallback closes #163788 Related: odoo/documentation#9116 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 28, 2024
closes #9116 Related: odoo/odoo#163788 Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
AntoineVDV
reviewed
May 30, 2024
| On Debian/Ubuntu, the following commands should install the required packages: | ||
|
|
||
| .. code-block:: console | ||
|
|
||
| $ cd /CommunityPath | ||
| $ sed -n -e '/^Depends:/,/^Pre/ s/ python3-\(.*\),/python3-\1/p' debian/control | sudo xargs apt-get install -y | ||
| $ cd odoo #CommunityPath |
There was a problem hiding this comment.
The CommunityPath placeholder is explained above and presented in the /CommunityPath format in commands in many other places on this page; let's keep it.
Suggested change
| $ cd odoo #CommunityPath | |
| $ cd /CommunityPath |
It could maybe be made clearer, but then it should be done for the entire page at once, not just this one command block.
Comment on lines
+289
to
+291
|
|
||
| Using pip may lead to security issue and broken dependencies, only do this if you | ||
| know what you rare doing. |
There was a problem hiding this comment.
- removed extra line
- issues
- , -> ;
- rare -> are
Suggested change
| Using pip may lead to security issue and broken dependencies, only do this if you | |
| know what you rare doing. | |
| Using pip may lead to security issues and broken dependencies; only do this if you | |
| know what you are doing. |
This was referenced May 30, 2024
|
@Xavier-Do this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@Xavier-Do this pull request has forward-port PRs awaiting action (not merged or closed): |
lohwswilson
pushed a commit
to lohwswilson/odoo
that referenced
this pull request
Jun 3, 2024
lxml.hml.clean was moved to a separate package starting in lxml 5.2 The requirements and debian control needs to be adapted to install the new package in ubuntu noble (and after ubuntu noble only) The solution was to use fallback to try to install lxml_html_clean if it exists (noble) and fallback on lxml if not. The script use in the documentation and available in more recent version will take all first packge of the debian conrtol, meaning that after this change it won't work in distribution not having lxml_html_clean. The script is adapted to use fallback in apt-install command Debian control: font1 | font2, package_1, package_noble | package_fallback, Before: apt install font1 package package_noble After: apt install font1|font2 package package_noble|package_fallback closes odoo#163788 Related: odoo/documentation#9116 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
|
@Xavier-Do this pull request has forward-port PRs awaiting action (not merged or closed): |
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debian/controll changed making the previous sed outdated, adapt to use a script for an easier onboarding and mainteance.
Also, warn user that pip option is not adviced.