[FIX] packaging: lxml_html_clean_split #163788
Closed
+32
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Xavier-Do
force-pushed
the
15.0-noble-packaging-xdo
branch
from
7a43f3b
to
36a282a
Compare
Xavier-Do
force-pushed
the
15.0-noble-packaging-xdo
branch
from
36a282a
to
4a067f9
Compare
This was referenced May 10, 2024
Xavier-Do
force-pushed
the
15.0-noble-packaging-xdo
branch
3 times, most recently
from
6bef500
to
278035e
Compare
Xavier-Do
force-pushed
the
15.0-noble-packaging-xdo
branch
4 times, most recently
from
91ed094
to
fb52193
Compare
lxml.hml.clean was moved to a separate package starting in lxml 5.2 The requirements and debian control needs to be adapted to install the new package in ubuntu noble (and after ubuntu noble only) The solution was to use fallback to try to install lxml_html_clean if it exists (noble) and fallback on lxml if not. The script use in the documentation and available in more recent version will take all first packge of the debian conrtol, meaning that after this change it won't work in distribution not having lxml_html_clean. The script is adapted to use fallback in apt-install command Debian control: font1 | font2, package_1, package_noble | package_fallback, Before: apt install font1 package package_noble After: apt install font1|font2 package package_noble|package_fallback
Xavier-Do
force-pushed
the
15.0-noble-packaging-xdo
branch
from
fb52193
to
fedcc27
Compare
|
robodoo r+ |
|
@Xavier-Do @d-fence linked pull request(s) odoo/documentation#9116 not ready. Linked PRs are not staged until all of them are ready. |
robodoo
pushed a commit
that referenced
this pull request
May 28, 2024
lxml.hml.clean was moved to a separate package starting in lxml 5.2 The requirements and debian control needs to be adapted to install the new package in ubuntu noble (and after ubuntu noble only) The solution was to use fallback to try to install lxml_html_clean if it exists (noble) and fallback on lxml if not. The script use in the documentation and available in more recent version will take all first packge of the debian conrtol, meaning that after this change it won't work in distribution not having lxml_html_clean. The script is adapted to use fallback in apt-install command Debian control: font1 | font2, package_1, package_noble | package_fallback, Before: apt install font1 package package_noble After: apt install font1|font2 package package_noble|package_fallback closes #163788 Related: odoo/documentation#9116 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
robodoo
pushed a commit
to odoo/documentation
that referenced
this pull request
May 28, 2024
closes #9116 Related: odoo/odoo#163788 Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 28, 2024
lxml.hml.clean was moved to a separate package starting in lxml 5.2 The requirements and debian control needs to be adapted to install the new package in ubuntu noble (and after ubuntu noble only) The solution was to use fallback to try to install lxml_html_clean if it exists (noble) and fallback on lxml if not. The script use in the documentation and available in more recent version will take all first packge of the debian conrtol, meaning that after this change it won't work in distribution not having lxml_html_clean. The script is adapted to use fallback in apt-install command Debian control: font1 | font2, package_1, package_noble | package_fallback, Before: apt install font1 package package_noble After: apt install font1|font2 package package_noble|package_fallback closes #163788 Related: odoo/documentation#9116 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
robodoo
pushed a commit
to odoo/documentation
that referenced
this pull request
May 28, 2024
closes #9116 Related: odoo/odoo#163788 Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
This was referenced May 28, 2024
|
@Xavier-Do @d-fence this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@Xavier-Do @d-fence this pull request has forward-port PRs awaiting action (not merged or closed): |
lohwswilson
pushed a commit
to lohwswilson/odoo
that referenced
this pull request
Jun 3, 2024
lxml.hml.clean was moved to a separate package starting in lxml 5.2 The requirements and debian control needs to be adapted to install the new package in ubuntu noble (and after ubuntu noble only) The solution was to use fallback to try to install lxml_html_clean if it exists (noble) and fallback on lxml if not. The script use in the documentation and available in more recent version will take all first packge of the debian conrtol, meaning that after this change it won't work in distribution not having lxml_html_clean. The script is adapted to use fallback in apt-install command Debian control: font1 | font2, package_1, package_noble | package_fallback, Before: apt install font1 package package_noble After: apt install font1|font2 package package_noble|package_fallback closes odoo#163788 Related: odoo/documentation#9116 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
|
@Xavier-Do @d-fence this pull request has forward-port PRs awaiting action (not merged or closed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since lxml 5.2 (lxml/lxml@7377868) lxml_html_clean is in another package
We can adapt the requirements after python 3.12 (based on ubuntu 24.04)
We can use | operator in debian/control
We may need to adapt documentation since the current sed script will fail
This pr proposes an alternative script to avoid to use a sed
Current sed:
sed -n -e '/^Depends:/,/^Pre/ s/ python3-\(.*\),/python3-\1/p' debian/controlThis sed will fail and give the result
python3-lxml-html-clean | python3-lxmlfor the lxml line, we need to remove the spaces