-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] inventory: sendcloud shipping info #9436
Conversation
Hello @hojo-odoo ! This quick update PR with <50 lines is ready for your first round of peer review 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst
Outdated
Show resolved
Hide resolved
f84bb5e
to
3ccc6ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @Felicious -- just finished my Final Review of this PR. Great work. Only have a few minor suggestions that require your attention. Once you address those, and implement the necessary adjustments, you can feel free to tag this for Tech Review. Thanks! 👍
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst
Outdated
Show resolved
Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst
Outdated
Show resolved
Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst
Outdated
Show resolved
Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst
Outdated
Show resolved
Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst
Outdated
Show resolved
Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst
Outdated
Show resolved
Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst
Outdated
Show resolved
Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst
Outdated
Show resolved
Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst
Outdated
Show resolved
Hide resolved
Hi @odoo/us-doc-review, this 50 line PR is ready for your final review :D |
a3c185c
to
f7dedef
Compare
Hello @samueljlieber ! This ~60 line PR is ready for your tech review (: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Felicious, your changes look good to me! Thank you for your work :)
Approving with a couple comments, thanks!
..
@robodoo delegate=Felicious
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst
Outdated
Show resolved
Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst
Outdated
Show resolved
Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: hojo-odoo <123424465+hojo-odoo@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
782a7ec
to
7bb5053
Compare
@robodoo r+ |
closes #9436 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com> Co-authored-by: hojo-odoo <123424465+hojo-odoo@users.noreply.github.com> Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com> Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
@Felicious this pull request has forward-port PRs awaiting action (not merged or closed): |
@Felicious this pull request has forward-port PRs awaiting action (not merged or closed): |
@Felicious this pull request has forward-port PRs awaiting action (not merged or closed): |
1 similar comment
@Felicious this pull request has forward-port PRs awaiting action (not merged or closed): |
Summary
Fwport: yes!
Task