Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] inventory: sendcloud shipping info #9436

Closed
wants to merge 1 commit into from
Closed

[IMP] inventory: sendcloud shipping info #9436

wants to merge 1 commit into from

Conversation

Felicious
Copy link
Contributor

Summary

  1. Implement @moch-odoo's feedback
  2. Add more detailed instructions about configuring customer information, product weights, and warehouse addresses in Odoo.

Fwport: yes!

Task

@Felicious Felicious added the 2 label May 21, 2024
@Felicious Felicious self-assigned this May 21, 2024
@Felicious Felicious requested a review from hojo-odoo May 21, 2024 22:14
@robodoo
Copy link
Collaborator

robodoo commented May 21, 2024

Pull request status dashboard.

@Felicious
Copy link
Contributor Author

Hello @hojo-odoo ! This quick update PR with <50 lines is ready for your first round of peer review 😊

@C3POdoo C3POdoo requested a review from a team May 21, 2024 22:15
hojo-odoo
hojo-odoo approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@hojo-odoo hojo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Felicious,

Great job on this doc. I'm approving with just one comment.

Thanks,
John

...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst Outdated Show resolved Hide resolved
@Felicious Felicious force-pushed the 16.0-inventory-sendcloud-checklist-feku branch from f84bb5e to 3ccc6ac Compare May 24, 2024 17:01
@Felicious Felicious requested a review from a team May 24, 2024 17:02
ksc-odoo
ksc-odoo approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Felicious -- just finished my Final Review of this PR. Great work. Only have a few minor suggestions that require your attention. Once you address those, and implement the necessary adjustments, you can feel free to tag this for Tech Review. Thanks! 👍

...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst Outdated Show resolved Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst Outdated Show resolved Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst Outdated Show resolved Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst Outdated Show resolved Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst Outdated Show resolved Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst Outdated Show resolved Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst Outdated Show resolved Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst Outdated Show resolved Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst Outdated Show resolved Hide resolved
@Felicious
Copy link
Contributor Author

Hi @odoo/us-doc-review, this 50 line PR is ready for your final review :D

@Felicious Felicious closed this May 24, 2024
@Felicious Felicious reopened this May 24, 2024
@Felicious Felicious force-pushed the 16.0-inventory-sendcloud-checklist-feku branch from a3c185c to f7dedef Compare May 24, 2024 18:54
@Felicious
Copy link
Contributor Author

Hello @samueljlieber ! This ~60 line PR is ready for your tech review (:

@samueljlieber samueljlieber requested a review from a team May 24, 2024 20:58
samueljlieber
samueljlieber approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Felicious, your changes look good to me! Thank you for your work :)
Approving with a couple comments, thanks!
..
@robodoo delegate=Felicious

...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst Outdated Show resolved Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst Outdated Show resolved Hide resolved
...ns/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/sendcloud_shipping.rst Outdated Show resolved Hide resolved
@Felicious @hojo-odoo
@ksc-odoo @samueljlieber
[IMP] inventory: sendcloud shipping info
7bb5053 
Co-authored-by: hojo-odoo <123424465+hojo-odoo@users.noreply.github.com>
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
@Felicious Felicious force-pushed the 16.0-inventory-sendcloud-checklist-feku branch from 782a7ec to 7bb5053 Compare May 24, 2024 21:40
@Felicious
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request May 25, 2024
@Felicious @hojo-odoo
@ksc-odoo @samueljlieber
[IMP] inventory: sendcloud shipping info
6305211 
closes #9436

Signed-off-by: Felicia Kuan (feku) <feku@odoo.com>
Co-authored-by: hojo-odoo <123424465+hojo-odoo@users.noreply.github.com>
Co-authored-by: ksc-odoo <73958186+ksc-odoo@users.noreply.github.com>
Co-authored-by: Sam Lieber (sali) <36018073+samueljlieber@users.noreply.github.com>
@fw-bot fw-bot mentioned this pull request May 25, 2024
Closed
@robodoo robodoo closed this May 25, 2024
This was referenced May 25, 2024
Closed
Closed
Closed
Closed
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented May 28, 2024

@Felicious this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented May 29, 2024

@Felicious this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented May 30, 2024

@Felicious this pull request has forward-port PRs awaiting action (not merged or closed):

1 similar comment
@fw-bot
Copy link
Collaborator

fw-bot commented May 31, 2024

@Felicious this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueljlieber samueljlieber samueljlieber approved these changes

@ksc-odoo ksc-odoo ksc-odoo approved these changes

@hojo-odoo hojo-odoo hojo-odoo approved these changes

Assignees

@Felicious Felicious

Labels
2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Felicious @robodoo @fw-bot @samueljlieber @ksc-odoo @hojo-odoo