Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] clipboard: invalidate clipboard when inserting col/row before cut #1431

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jun 14, 2022

Adding or removing col/rows before/inside a cut area will now invalidate
the clipboard. 266221d only fixed col/rows inserted inside the cut area.

Ideally we would want to adapt the clipboard zone instead of invalidating
the clipboard, but it's a bigger change that won't be done in 15.0 (task 2712533).

Odoo task ID : 2862400

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #1386

…ut zone

Adding or removing col/rows before/inside a cut area will now invalidate
the clipboard. 266221d only fixed col/rows inserted inside the cut area.

Ideally we would want to adapt the clipboard zone instead of invalidating
the clipboard, but it's a bigger change that won't be done in 15.0 (task 2712533).

Odoo task 2862400

X-original-commit: c0d8ae7
@robodoo
Copy link
Collaborator

robodoo commented Jun 14, 2022

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jun 14, 2022

This PR targets saas-15.3 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jun 14, 2022

Ping @hokolomopo, @pro-odoo
The next pull request (#1432) is in conflict. You can merge the chain up to here by saying

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@pro-odoo
Copy link
Collaborator

@fw-bot r+

robodoo pushed a commit that referenced this pull request Jun 14, 2022
…ut zone

Adding or removing col/rows before/inside a cut area will now invalidate
the clipboard. 266221d only fixed col/rows inserted inside the cut area.

Ideally we would want to adapt the clipboard zone instead of invalidating
the clipboard, but it's a bigger change that won't be done in 15.0 (task 2712533).

Odoo task 2862400

closes #1431

X-original-commit: c0d8ae7
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
@robodoo robodoo closed this Jun 14, 2022
@robodoo robodoo temporarily deployed to merge June 14, 2022 06:49 Inactive
@fw-bot fw-bot deleted the saas-15.3-15.0-clipboard-invalidate-cut-adrm-70TQ-fw branch June 28, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants