Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Selection: Altering selection should scroll the viewport #1775

Closed
wants to merge 1 commit into from
Closed

[FIX] Selection: Altering selection should scroll the viewport #1775

wants to merge 1 commit into from

Commits on Nov 21, 2022

  1. [FIX] selection: Altering selection should scroll the viewport 

    Commit b437f44 introduced an error. while fixing the viewport
scrolling while in autofill (it shouldn't happen) it also prevent an
change of selection (not an extension) to properly scroll the viewport.

The problem ultimately lies in the fact that the autofill was using the
selectionProcessor to override its selection instead of extending it.

In order to fix this, it was necessary to alter the API of the
selection processor to allow more granularity in the steps to extend a
zone selection: i.e. instead of a step of 1 or jump to the end of a zone,
we need to support all POSITIVE values of steps.

Task 3050101
    @rrahir @LucasLefevre
    rrahir authored and LucasLefevre committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    c39291e View commit details
    Browse the repository at this point in the history