[FIX] Selection: Altering selection should scroll the viewport #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrahir
changed the title
rrahir
force-pushed
the
saas-15.3-fix-selection-again-no-days-off-rar
branch
from
c143b27
to
c6ac43b
Compare
LucasLefevre
approved these changes
Nov 4, 2022
| this.autofillZone = undefined; | ||
| this.selection.resizeAnchorZone(this.direction, this.steps); |
There was a problem hiding this comment.
yep, looks like what it should have been from the start
| @@ -142,7 +142,10 @@ export class SelectionStreamProcessor | |||
| /** | |||
| * Set the selection to one of the cells adjacent to the current anchor cell. | |||
| */ | |||
| moveAnchorCell(direction: SelectionDirection, step: SelectionStep = "one"): DispatchResult { | |||
| moveAnchorCell(direction: SelectionDirection, step: SelectionStep = 1): DispatchResult { | |||
| if (step !== "end" && step <= 0) { | |||
There was a problem hiding this comment.
Does it work when step=0 ? Probably yes, but it's worth a test
src/helpers/zones.ts
Outdated
| @@ -487,7 +487,7 @@ export function mergeOverlappingZones(zones: Zone[]) { | |||
| export function findCellInNewZone( | |||
| oldZone: Zone, | |||
| currentZone: Zone, | |||
| viewport: Viewport | |||
| viewport?: Viewport | |||
There was a problem hiding this comment.
maybe update the docstring to help understanding what impact the viewport has
14 tasks
rrahir
force-pushed
the
saas-15.3-fix-selection-again-no-days-off-rar
branch
4 times, most recently
from
49f77af
to
f22726e
Compare
Commit b437f44 introduced an error. while fixing the viewport scrolling while in autofill (it shouldn't happen) it also prevent an change of selection (not an extension) to properly scroll the viewport. The problem ultimately lies in the fact that the autofill was using the selectionProcessor to override its selection instead of extending it. In order to fix this, it was necessary to alter the API of the selection processor to allow more granularity in the steps to extend a zone selection: i.e. instead of a step of 1 or jump to the end of a zone, we need to support all POSITIVE values of steps. Task 3050101
LucasLefevre
force-pushed
the
saas-15.3-fix-selection-again-no-days-off-rar
branch
from
f22726e
to
c39291e
Compare
robodoo
pushed a commit
that referenced
this pull request
Nov 21, 2022
Commit b437f44 introduced an error. while fixing the viewport scrolling while in autofill (it shouldn't happen) it also prevent an change of selection (not an extension) to properly scroll the viewport. The problem ultimately lies in the fact that the autofill was using the selectionProcessor to override its selection instead of extending it. In order to fix this, it was necessary to alter the API of the selection processor to allow more granularity in the steps to extend a zone selection: i.e. instead of a step of 1 or jump to the end of a zone, we need to support all POSITIVE values of steps. Task 3050101 closes #1775 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
This was referenced Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Odoo task ID : 3050101
review checklist