Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] config: Allow to build outside of git repository #1789

Closed
wants to merge 1 commit into from
Closed

[FIX] config: Allow to build outside of git repository #1789

wants to merge 1 commit into from

Conversation

rrahir
Copy link
Collaborator

@rrahir rrahir commented Nov 3, 2022

The lib used to extract the hash commit will raise when run outside a git repository. Since we need to perform this action on runbot, we catch the error in that specific case.

Description:

description of this task, what is implemented and why it is implemented that way.

Odoo task ID : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@rrahir
[FIX] config: Allow to build outside of git repository
a3e75a5 
The lib used to extract the hash commit will raise when run outside a
git repository. Since we need to perform this action on runbot, we catch
the error in that specific case.
@robodoo
Copy link
Collaborator

robodoo commented Nov 3, 2022

Pull request status dashboard.

LucasLefevre
LucasLefevre approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Nov 3, 2022
@rrahir
[FIX] config: Allow to build outside of git repository
75e08d7 
The lib used to extract the hash commit will raise when run outside a
git repository. Since we need to perform this action on runbot, we catch
the error in that specific case.

closes #1789

Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo temporarily deployed to merge November 3, 2022 15:32 Inactive
@robodoo robodoo closed this Nov 3, 2022
This was referenced Nov 3, 2022
Closed
Closed
Closed
Closed
Closed
@fw-bot fw-bot deleted the 14.0-build-with-no-git-rar branch November 17, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasLefevre LucasLefevre LucasLefevre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rrahir @robodoo @LucasLefevre