Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] config: Allow to build outside of git repository #1792

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 3, 2022

The lib used to extract the hash commit will raise when run outside a git repository. Since we need to perform this action on runbot, we catch the error in that specific case.

Description:

description of this task, what is implemented and why it is implemented that way.

Odoo task ID : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #1789

The lib used to extract the hash commit will raise when run outside a
git repository. Since we need to perform this action on runbot, we catch
the error in that specific case.

X-original-commit: 75e08d7
@robodoo
Copy link
Collaborator

robodoo commented Nov 3, 2022

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 3, 2022

This PR targets saas-15.3 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@rrahir
Copy link
Collaborator

rrahir commented Nov 3, 2022

@fw-bot r+

robodoo pushed a commit that referenced this pull request Nov 3, 2022
The lib used to extract the hash commit will raise when run outside a
git repository. Since we need to perform this action on runbot, we catch
the error in that specific case.

closes #1792

X-original-commit: 75e08d7
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo temporarily deployed to merge November 3, 2022 16:33 Inactive
@robodoo robodoo closed this Nov 3, 2022
@fw-bot fw-bot deleted the saas-15.3-14.0-build-with-no-git-rar-W5El-fw branch November 17, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants