Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] Selection: Altering selection should scroll the viewport #1824

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 22, 2022

Description:

description of this task, what is implemented and why it is implemented that way.

Odoo task ID : 3050101

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #1823
Forward-Port-Of: #1775

@robodoo
Copy link
Collaborator

robodoo commented Nov 22, 2022

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 22, 2022

@rrahir @LucasLefevre cherrypicking of pull request #1775 failed.

stderr:

10:34:06.467237 git.c:344               trace: built-in: git cherry-pick f8823b495186cb3f6064ade7f372aa2fb8375336
error: could not apply f8823b49... [FIX] selection: Altering selection should scroll the viewport
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

Commit b437f44 introduced an error. while fixing the viewport
scrolling while in autofill (it shouldn't happen) it also prevent an
change of selection (not an extension) to properly scroll the viewport.

The problem ultimately lies in the fact that the autofill was using the
selectionProcessor to override its selection instead of extending it.

In order to fix this, it was necessary to alter the API of the
selection processor to allow more granularity in the steps to extend a
zone selection: i.e. instead of a step of 1 or jump to the end of a zone,
we need to support all POSITIVE values of steps.

Task 3050101

X-original-commit: b167b3e
@rrahir rrahir force-pushed the master-saas-15.3-fix-selection-again-no-days-off-rar-AECW-fw branch from 89fcbd2 to 98f81f6 Compare November 22, 2022 10:05
@rrahir
Copy link
Collaborator

rrahir commented Nov 22, 2022

@robodoo r+

@robodoo robodoo temporarily deployed to merge November 22, 2022 10:16 Inactive
@robodoo robodoo closed this in ae0e8d9 Nov 22, 2022
@robodoo robodoo added the 16.1 label Nov 22, 2022
@fw-bot fw-bot deleted the master-saas-15.3-fix-selection-again-no-days-off-rar-AECW-fw branch December 6, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants