[IMP/REF] tests: mount owl App in test mode & mount helper #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrahir
reviewed
Feb 3, 2023
pro-odoo
reviewed
Feb 3, 2023
tests/components/bottom_bar.test.ts
Outdated
| @@ -38,7 +38,7 @@ async function mountBottomBar( | |||
| env: Partial<SpreadsheetChildEnv> = {} | |||
| ): Promise<{ parent: Parent; app: App; model: Model }> { | |||
| const mockEnv = makeTestEnv({ ...env, model }); | |||
| const app = new App(Parent, { props: { model }, env: mockEnv }); | |||
| const app = new App(Parent, { props: { model }, env: mockEnv, test: true }); | |||
There was a problem hiding this comment.
What do you think about creating a helper to mount a component ?
async function mount(component, target, props={}, env={}) {
const app = new App(component, { props, env, test: true });
app.addTemplates(OWL_TEMPLATES);
const parent = await app.mount(target);
return { app, parent }
}With that, we could avoid thinking of adding test: true, OWL_TEMPLATES, ...
hokolomopo
force-pushed
the
master-app-test-mode-adrm
branch
2 times, most recently
from
7ec3d3a
to
4bb6239
Compare
hokolomopo
changed the title
hokolomopo
changed the title
hokolomopo
force-pushed
the
master-app-test-mode-adrm
branch
from
4bb6239
to
03de83c
Compare
…elper Change the parameters of the owl `App` in the test. The `App` will now be mounted in test mode. The main purpose is to enable props validation, which ensure that the test is close to the reality, and avoid tests failing for unclear reasons because a props was missing (d466315). The Owl test mode is equivalent to dev mode, but without warning that the app is unsuited for production. Documentation here : https://github.com/odoo/owl/blob/master/doc/reference/app.md#dev-mode Also added an helper `mountComponent` and modified the existing helper `mountSpreadsheet`. The helpers now create and return the fixture in which the component is mounted. They also register cleanup functions to remove the fixture and destroy the app, so we don't have to do it manually.
hokolomopo
force-pushed
the
master-app-test-mode-adrm
branch
from
03de83c
to
0ef6bdb
Compare
rrahir
pushed a commit
that referenced
this pull request
Mar 21, 2023
This commit is a backport of original merged in PR #2045, it was introduced as it diminishes drastically the sources of errors when mounting OWL components. Change the parameters of the owl `App` in the test. The `App` will now be mounted in test mode. The main purpose is to enable props validation, which ensure that the test is close to the reality, and avoid tests failing for unclear reasons because a props was missing (d466315). The Owl test mode is equivalent to dev mode, but without warning that the app is unsuited for production. Documentation here : https://github.com/odoo/owl/blob/master/doc/reference/app.md#dev-mode Also added an helper `mountComponent` and modified the existing helper `mountSpreadsheet`. The helpers now create and return the fixture in which the component is mounted. They also register cleanup functions to remove the fixture and destroy the app, so we don't have to do it manually. closes #2045 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 22, 2023
This commit is a backport of original merged in PR #2045, it was introduced as it diminishes drastically the sources of errors when mounting OWL components. Change the parameters of the owl `App` in the test. The `App` will now be mounted in test mode. The main purpose is to enable props validation, which ensure that the test is close to the reality, and avoid tests failing for unclear reasons because a props was missing (d466315). The Owl test mode is equivalent to dev mode, but without warning that the app is unsuited for production. Documentation here : https://github.com/odoo/owl/blob/master/doc/reference/app.md#dev-mode Also added an helper `mountComponent` and modified the existing helper `mountSpreadsheet`. The helpers now create and return the fixture in which the component is mounted. They also register cleanup functions to remove the fixture and destroy the app, so we don't have to do it manually. closes #2045 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Part-of: #2252
rrahir
pushed a commit
that referenced
this pull request
Mar 22, 2023
This commit is a backport of original merged in PR #2045, it was introduced as it diminishes drastically the sources of errors when mounting OWL components. Change the parameters of the owl `App` in the test. The `App` will now be mounted in test mode. The main purpose is to enable props validation, which ensure that the test is close to the reality, and avoid tests failing for unclear reasons because a props was missing (d466315). The Owl test mode is equivalent to dev mode, but without warning that the app is unsuited for production. Documentation here : https://github.com/odoo/owl/blob/master/doc/reference/app.md#dev-mode Also added an helper `mountComponent` and modified the existing helper `mountSpreadsheet`. The helpers now create and return the fixture in which the component is mounted. They also register cleanup functions to remove the fixture and destroy the app, so we don't have to do it manually. closes #2045 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 22, 2023
This commit is a backport of original merged in PR #2045, it was introduced as it diminishes drastically the sources of errors when mounting OWL components. Change the parameters of the owl `App` in the test. The `App` will now be mounted in test mode. The main purpose is to enable props validation, which ensure that the test is close to the reality, and avoid tests failing for unclear reasons because a props was missing (d466315). The Owl test mode is equivalent to dev mode, but without warning that the app is unsuited for production. Documentation here : https://github.com/odoo/owl/blob/master/doc/reference/app.md#dev-mode Also added an helper `mountComponent` and modified the existing helper `mountSpreadsheet`. The helpers now create and return the fixture in which the component is mounted. They also register cleanup functions to remove the fixture and destroy the app, so we don't have to do it manually. closes #2045 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Part-of: #2258
This was referenced Mar 22, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the parameters of the owl
Appin the test. TheAppwill nowbe mounted in test mode. The main purpose is to enable props validation,
which ensure that the test is close to the reality, and avoid tests
failing for unclear reasons because a props was missing (d466315).
The Owl test mode is equivalent to dev mode, but without warning that
the app is unsuited for production. Documentation here :
https://github.com/odoo/owl/blob/master/doc/reference/app.md#dev-mode
Also added an helper
mountComponentand modified the existing helpermountSpreadsheet. The helper now creates and returns the fixture in whichthe component is mounted. They also register cleanup functions to remove
the fixture and destroy the app, so we don't have to do it manually.
Description:
description of this task, what is implemented and why it is implemented that way.
Odoo task ID : TASK_ID
review checklist