[FW] Bump owl version #2258
Closed
[FW] Bump owl version #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rrahir @LucasLefevre cherrypicking of pull request #2252 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
rrahir
force-pushed
the
saas-16.1-16.0-bump-owl-rar-i5ZO-fw
branch
from
7e1fc10
to
2bfb3f5
Compare
|
@robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward. |
|
@robodoo r- |
This commit is a backport of original merged in PR #2045, it was introduced as it diminishes drastically the sources of errors when mounting OWL components. Change the parameters of the owl `App` in the test. The `App` will now be mounted in test mode. The main purpose is to enable props validation, which ensure that the test is close to the reality, and avoid tests failing for unclear reasons because a props was missing (d466315). The Owl test mode is equivalent to dev mode, but without warning that the app is unsuited for production. Documentation here : https://github.com/odoo/owl/blob/master/doc/reference/app.md#dev-mode Also added an helper `mountComponent` and modified the existing helper `mountSpreadsheet`. The helpers now create and return the fixture in which the component is mounted. They also register cleanup functions to remove the fixture and destroy the app, so we don't have to do it manually. closes #2045 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
catching up to odoo version 2.0.9
rrahir
force-pushed
the
saas-16.1-16.0-bump-owl-rar-i5ZO-fw
branch
from
2bfb3f5
to
5443e42
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 22, 2023
This commit is a backport of original merged in PR #2045, it was introduced as it diminishes drastically the sources of errors when mounting OWL components. Change the parameters of the owl `App` in the test. The `App` will now be mounted in test mode. The main purpose is to enable props validation, which ensure that the test is close to the reality, and avoid tests failing for unclear reasons because a props was missing (d466315). The Owl test mode is equivalent to dev mode, but without warning that the app is unsuited for production. Documentation here : https://github.com/odoo/owl/blob/master/doc/reference/app.md#dev-mode Also added an helper `mountComponent` and modified the existing helper `mountSpreadsheet`. The helpers now create and return the fixture in which the component is mounted. They also register cleanup functions to remove the fixture and destroy the app, so we don't have to do it manually. closes #2045 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Part-of: #2258
robodoo
pushed a commit
that referenced
this pull request
Mar 22, 2023
catching up to odoo version 2.0.9 closes #2258 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
this PR bumps the version of OWL in o-spreadshset to catch up with its counterpart in odoo: version 2.0.9
One major change (one could argue breaking) is that the property
elof aRefis nowundefinedonce the component is no longer mounted. This change of behaviour highlighted several issues in our tests setup. Since several of them were addressed in PR #2045, it was decided to backport the said pull request in version 16.0 to ease the transition of owl versions.Odoo task ID : TASK_ID
review checklist
Forward-Port-Of: #2252