[IMP] history: add the possibility to repeat commands at redo #2126

hokolomopo · 2023-03-01T09:27:00Z

Description:

Now if we do a redo and the redo stack is empty, we will try the redo
the last played command if possible. The list of repeatable commands
is in defined in the repeat_commands_registry.ts file.

Repeated commands are transformed to match the current selection/sheet.
To be able to repeat local commands, the "root" command of a revision
was added to the history.

Odoo task ID : 2508693

review checklist

robodoo · 2023-03-01T09:27:22Z

Pull request status dashboard.

anhe-odoo

Good work. Some small questions but else look good to me :)

tests/plugins/repeat_commands.test.ts

src/collaborative/session.ts

src/history/repeat_commands/repeat_commands_generic.ts

src/history/repeat_commands/repeat_commands_specific.ts

src/plugins/ui_stateful/clipboard.ts

LucasLefevre

coucou :)

src/collaborative/revisions.ts

src/history/local_history.ts

src/history/factory.ts

src/history/repeat_commands/repeat_commands_generic.ts

src/history/repeat_commands/repeat_commands_specific.ts

LucasLefevre · 2023-04-11T09:12:18Z

src/registries/repeat_commands_registry.ts

+}
+
+/** Apply generic transforms (sheetID, target, ...) to the core command children of a local command */
+export function getRepeatedLocalCommandChildrenGeneric<T extends LocalCommand>(


this function is only used once for STOP_EDITION. maybe we could just move (and rename) this to a specific repeat function repeatStopEdition. It would be easier to understand than this kinda barbaric function name

If I don't need to use it as a generic for odoo commands, I'll do that yeah.

Looks like we don't need that in odoo, changed it to repeatStopEdition

Edit: cannot make it into a specific transform because of cyclic imports. repeat_commands_registry.ts need repeatStopEdition to put in the registry => repeatStopEdition need repeatCoreCommand => repeatCoreCommand need the registry.

I put it back in this file, but changed the name to repeatLocalCommandChildren which is less of a mouthful

src/types/commands.ts

src/history/repeat_commands/repeat_revision.ts

src/model.ts

LucasLefevre

bloup bloup :)
Almost ready :)

src/plugins/ui_plugin.ts

LucasLefevre · 2023-04-13T09:20:41Z

src/registries/repeat_commands_registry.ts

+  return repeatTransform(getters, command, childCommands);
+}
+
+export function getRepeatedCoreCommands(


I would move those "generic" helper functions to repeat_revision.ts

The reason I put them there is to avoid cyclic dependencies :x

src/registries/repeat_commands_registry.ts

tests/plugins/history.test.ts

tests/test_helpers/constants.ts

src/model.ts

rrahir · 2023-04-19T06:31:57Z

src/history/repeat_commands/repeat_commands_generic.ts

+  repeatPositionDependantCommand,
+];
+
+export function repeatSheetDependantCommand<T extends Command>(getters: Getters, command: T): T {


Just realized this but it's actually spelled dependent in American English, we should change that at some point

src/plugins/ui_feature/local_history.ts

src/types/misc.ts

src/registries/repeat_commands_registry.ts

rrahir · 2023-04-19T08:34:02Z

src/collaborative/session.ts

@@ -193,6 +200,17 @@ export class Session extends EventBus<CollaborativeEvent> {
    return this.pendingMessages.length === 0;
  }

+  /** Get the last local revision that doesn't come from a REQUEST_REDO command */
+  getLastLocalNonRedoRevision(): Revision | undefined {
+    const revisions = this.revisions.getRevertedExecution();


nitpick as most of my comments but I don't like this function - it could technically capture a "REQUEST_UNDO" command, it's just that we don't call the function in that case because the presence of request undo in the session implies the existence of some commands in the undo stack inside local history but the session is unaware of the undo/redo stack. I think it should be more 'draconian' or at least add some comments/check where it is called.

After looking a bit into that, if I understand correctly revisions from standard undo/redo are created inside the selective_history, and are empty. So they are not returned in this method. But this isn't very intuitive, so I changed things a bit and added a comment.

LMK if the code looks clearer now

src/history/factory.ts

rrahir · 2023-04-19T14:47:17Z

forgot to mention the circular dependency at build :/

doc/extending/command.md

The commit transform the history into a standard UI feature plugin. To do that : - the session is now given to the constructor of the UI plugins - `session.on("revison-redone")` and `session.on("revison-undone")` are now handled directly in the model, as they need `dispatchFromCorePlugin` Task: 2508693

Task: 2508693

Now if we do a redo and the redo stack is empty, we will try the redo the last played command if possible. The list of repeatable commands is defined in the repeat_commands_registry.ts file. Repeated commands are transformed to match the current selection/sheet. To be able to repeat local commands, the "root" command of a revision was added to the history. Locals commands of stateful UI plugins cannot be simply transformed and repeated, because the state of The plugin may have changed. There is 2 strategies to solve this : 1. If possible, transform core sub-commands instead (eg. STOP_EDITION) 2. If not possible, we have to store the last state of the plugin, and dispatch a new commands REPEAT_* (eg. REPEAT_PASTE) It's not possible to adapt the sub-commands of the paste command, because they are dependant on the state of the sheet, and may change based on the paste location. A simple example is that paste create new col/rows for the clipboard content to fit the sheet. So there will be ADD_COL_ROW_COMMANDS in the sub commands in the history, but repeating paste might not need them. Or they could only needed for the repeated paste, not for the original. Task: 2508693

LucasLefevre

robodoo r+

LucasLefevre · 2023-04-20T12:58:34Z

robodoo rebase-ff bordel 😬

The commit transform the history into a standard UI feature plugin. To do that : - the session is now given to the constructor of the UI plugins - `session.on("revison-redone")` and `session.on("revison-undone")` are now handled directly in the model, as they need `dispatchFromCorePlugin` Task: 2508693 Part-of: #2126

Task: 2508693 Part-of: #2126

Now if we do a redo and the redo stack is empty, we will try the redo the last played command if possible. The list of repeatable commands is defined in the repeat_commands_registry.ts file. Repeated commands are transformed to match the current selection/sheet. To be able to repeat local commands, the "root" command of a revision was added to the history. Locals commands of stateful UI plugins cannot be simply transformed and repeated, because the state of The plugin may have changed. There is 2 strategies to solve this : 1. If possible, transform core sub-commands instead (eg. STOP_EDITION) 2. If not possible, we have to store the last state of the plugin, and dispatch a new commands REPEAT_* (eg. REPEAT_PASTE) It's not possible to adapt the sub-commands of the paste command, because they are dependant on the state of the sheet, and may change based on the paste location. A simple example is that paste create new col/rows for the clipboard content to fit the sheet. So there will be ADD_COL_ROW_COMMANDS in the sub commands in the history, but repeating paste might not need them. Or they could only needed for the repeated paste, not for the original. closes #2126 Task: 2508693 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

robodoo · 2023-04-20T12:59:10Z

Merge method set to rebase and fast-forward.

Since pull request 2126[^1], the shortcut F4 is handled by the grid component. Unfortunately, the same shortcut is handled in the composer as well and its propabation was not stopped. This means that a user wanting to loop the references inside their formula could see some unexpected side effects due to the grid replaying some commands. [^1]: #2126 Task: 3916488

Since pull request 2126[^1], the shortcut F4 is handled by the grid component. Unfortunately, the same shortcut is handled in the composer as well and its propabation was not stopped. This means that a user wanting to loop the references inside their formula could see some unexpected side effects due to the grid replaying some commands. [^1]: #2126 closes #4201 Task: 3916488 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

Since pull request 2126[^1], the shortcut F4 is handled by the grid component. Unfortunately, the same shortcut is handled in the composer as well and its propabation was not stopped. This means that a user wanting to loop the references inside their formula could see some unexpected side effects due to the grid replaying some commands. [^1]: #2126 Task: 3916488 X-original-commit: be5500d

Since pull request 2126[^1], the shortcut F4 is handled by the grid component. Unfortunately, the same shortcut is handled in the composer as well and its propabation was not stopped. This means that a user wanting to loop the references inside their formula could see some unexpected side effects due to the grid replaying some commands. [^1]: #2126 closes #4217 Task: 3916488 X-original-commit: be5500d Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

Since pull request 2126[^1], the shortcut F4 is handled by the grid component. Unfortunately, the same shortcut is handled in the composer as well and its propabation was not stopped. This means that a user wanting to loop the references inside their formula could see some unexpected side effects due to the grid replaying some commands. [^1]: #2126 closes #4216 Task: 3916488 X-original-commit: be5500d Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

Since pull request 2126[^1], the shortcut F4 is handled by the grid component. Unfortunately, the same shortcut is handled in the composer as well and its propabation was not stopped. This means that a user wanting to loop the references inside their formula could see some unexpected side effects due to the grid replaying some commands. [^1]: #2126 Task: 3916488 X-original-commit: be5500d

Since pull request 2126[^1], the shortcut F4 is handled by the grid component. Unfortunately, the same shortcut is handled in the composer as well and its propabation was not stopped. This means that a user wanting to loop the references inside their formula could see some unexpected side effects due to the grid replaying some commands. [^1]: #2126 closes #4218 Task: 3916488 X-original-commit: be5500d Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

Since pull request 2126[^1], the shortcut F4 is handled by the grid component. Unfortunately, the same shortcut is handled in the composer as well and its propabation was not stopped. This means that a user wanting to loop the references inside their formula could see some unexpected side effects due to the grid replaying some commands. [^1]: #2126 Task: 3916488 X-original-commit: 5b7b84b

Since pull request 2126[^1], the shortcut F4 is handled by the grid component. Unfortunately, the same shortcut is handled in the composer as well and its propabation was not stopped. This means that a user wanting to loop the references inside their formula could see some unexpected side effects due to the grid replaying some commands. [^1]: #2126 closes #4219 Task: 3916488 X-original-commit: 5b7b84b Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

Since pull request 2126[^1], the shortcut F4 is handled by the grid component. Unfortunately, the same shortcut is handled in the composer as well and its propabation was not stopped. This means that a user wanting to loop the references inside their formula could see some unexpected side effects due to the grid replaying some commands. [^1]: #2126 Task: 3916488 X-original-commit: f0f1e3d

Since pull request 2126[^1], the shortcut F4 is handled by the grid component. Unfortunately, the same shortcut is handled in the composer as well and its propabation was not stopped. This means that a user wanting to loop the references inside their formula could see some unexpected side effects due to the grid replaying some commands. [^1]: #2126 closes #4221 Task: 3916488 X-original-commit: f0f1e3d Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

anhe-odoo reviewed Mar 8, 2023

View reviewed changes

hokolomopo force-pushed the master-redo-command-adrm branch from 786049c to 894aadf Compare March 9, 2023 09:55

hokolomopo force-pushed the master-redo-command-adrm branch from 894aadf to 869c94a Compare March 27, 2023 10:35

LucasLefevre reviewed Apr 11, 2023

View reviewed changes

hokolomopo force-pushed the master-redo-command-adrm branch 2 times, most recently from 90b37ac to 367d45e Compare April 12, 2023 08:33

LucasLefevre reviewed Apr 13, 2023

View reviewed changes

hokolomopo force-pushed the master-redo-command-adrm branch 4 times, most recently from b5cfc58 to b871128 Compare April 19, 2023 06:41

rrahir reviewed Apr 19, 2023

View reviewed changes

hokolomopo force-pushed the master-redo-command-adrm branch from cb54f5e to 41f65cf Compare April 20, 2023 10:36

rrahir reviewed Apr 20, 2023

View reviewed changes

doc/extending/command.md Outdated Show resolved Hide resolved

doc/extending/command.md Outdated Show resolved Hide resolved

hokolomopo added 3 commits April 20, 2023 14:24

[IMP] grid: add F4 shortcut to redo

4c392d7

Task: 2508693

hokolomopo force-pushed the master-redo-command-adrm branch from 41f65cf to 06a1000 Compare April 20, 2023 12:29

LucasLefevre approved these changes Apr 20, 2023

View reviewed changes

robodoo pushed a commit that referenced this pull request Apr 20, 2023

[IMP] grid: add F4 shortcut to redo

f48587d

Task: 2508693 Part-of: #2126

robodoo temporarily deployed to merge April 20, 2023 13:14 Inactive

robodoo closed this Apr 20, 2023

robodoo added the 16.3 label Apr 20, 2023

fw-bot deleted the master-redo-command-adrm branch May 4, 2023 13:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] history: add the possibility to repeat commands at redo #2126

[IMP] history: add the possibility to repeat commands at redo #2126

hokolomopo commented Mar 1, 2023

robodoo commented Mar 1, 2023

anhe-odoo left a comment

LucasLefevre left a comment

LucasLefevre Apr 11, 2023

hokolomopo Apr 11, 2023

hokolomopo Apr 14, 2023

hokolomopo Apr 20, 2023 •

edited

Loading

LucasLefevre left a comment •

edited

Loading

LucasLefevre Apr 13, 2023

hokolomopo Apr 14, 2023 •

edited

Loading

rrahir Apr 19, 2023

rrahir Apr 19, 2023

hokolomopo Apr 20, 2023 •

edited

Loading

rrahir commented Apr 19, 2023

LucasLefevre left a comment

LucasLefevre commented Apr 20, 2023

robodoo commented Apr 20, 2023

[IMP] history: add the possibility to repeat commands at redo #2126

[IMP] history: add the possibility to repeat commands at redo #2126

Conversation

hokolomopo commented Mar 1, 2023

Description:

review checklist

robodoo commented Mar 1, 2023

anhe-odoo left a comment

Choose a reason for hiding this comment

LucasLefevre left a comment

Choose a reason for hiding this comment

LucasLefevre Apr 11, 2023

Choose a reason for hiding this comment

hokolomopo Apr 11, 2023

Choose a reason for hiding this comment

hokolomopo Apr 14, 2023

Choose a reason for hiding this comment

hokolomopo Apr 20, 2023 • edited Loading

Choose a reason for hiding this comment

LucasLefevre left a comment • edited Loading

Choose a reason for hiding this comment

LucasLefevre Apr 13, 2023

Choose a reason for hiding this comment

hokolomopo Apr 14, 2023 • edited Loading

Choose a reason for hiding this comment

rrahir Apr 19, 2023

Choose a reason for hiding this comment

rrahir Apr 19, 2023

Choose a reason for hiding this comment

hokolomopo Apr 20, 2023 • edited Loading

Choose a reason for hiding this comment

rrahir commented Apr 19, 2023

LucasLefevre left a comment

Choose a reason for hiding this comment

LucasLefevre commented Apr 20, 2023

robodoo commented Apr 20, 2023

hokolomopo Apr 20, 2023 •

edited

Loading

LucasLefevre left a comment •

edited

Loading

hokolomopo Apr 14, 2023 •

edited

Loading

hokolomopo Apr 20, 2023 •

edited

Loading