Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] congif: enables type checking for binded functions #2524

Closed
wants to merge 1 commit into from
Closed

[IMP] congif: enables type checking for binded functions #2524

wants to merge 1 commit into from

Conversation

anhe-odoo
Copy link
Contributor

Task Description

Currently all binded function are type as any. This change aims to for type checking on binded function in TypeScript.

Related Task/PR

Review Checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@anhe-odoo
[IMP] congif: enables type checking for binded functions
c544630 
Task Description

Currently all binded function are type as any. This change aims to
for type checking on binded function in TypeScript.

Related Task/PR

Task-3344661
@robodoo
Copy link
Collaborator

robodoo commented Jun 1, 2023

Pull request status dashboard.

LucasLefevre
LucasLefevre approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Jun 1, 2023
@anhe-odoo
[IMP] congif: enables type checking for binded functions
360a22f 
Task Description

Currently all binded function are type as any. This change aims to
for type checking on binded function in TypeScript.

Related Task/PR

Task-3344661

closes #2524

Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo temporarily deployed to merge June 1, 2023 10:45 Inactive
@robodoo robodoo closed this Jun 1, 2023
This was referenced Jun 1, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Jun 5, 2023

@anhe-odoo @LucasLefevre this pull request has forward-port PRs awaiting action (not merged or closed):
#2546

@fw-bot fw-bot deleted the 14.0-config-check_type_binded_functions-3344661-anhe branch June 15, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasLefevre LucasLefevre LucasLefevre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anhe-odoo @robodoo @fw-bot @LucasLefevre