Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][IMP] congif: enables type checking for binded functions #2532

Closed
wants to merge 1 commit into from
Closed

[FW][IMP] congif: enables type checking for binded functions #2532

wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jun 1, 2023

Task Description

Currently all binded function are type as any. This change aims to for type checking on binded function in TypeScript.

Related Task/PR

Review Checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #2525
Forward-Port-Of: #2524

@anhe-odoo
[IMP] congif: enables type checking for binded functions
a326f1e 
Task Description

Currently all binded function are type as any. This change aims to
for type checking on binded function in TypeScript.

Related Task/PR

Task-3344661

X-original-commit: da501aa
@robodoo
Copy link
Collaborator

robodoo commented Jun 1, 2023

Pull request status dashboard.

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jun 1, 2023

This PR targets saas-15.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

robodoo pushed a commit that referenced this pull request Jun 1, 2023
@anhe-odoo
[IMP] congif: enables type checking for binded functions
143ed74 
Task Description

Currently all binded function are type as any. This change aims to
for type checking on binded function in TypeScript.

Related Task/PR

Task-3344661

closes #2532

X-original-commit: da501aa
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo temporarily deployed to merge June 1, 2023 20:35 Inactive
@robodoo robodoo closed this Jun 1, 2023
@fw-bot fw-bot deleted the saas-15.2-14.0-config-check_type_binded_functions-3344661-anhe-8VDt-fw branch June 15, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
forwardport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fw-bot @robodoo @anhe-odoo