Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][FIX] Fixed ($) full row/column references #3306

Closed
wants to merge 3 commits into from
Closed

[FW][FIX] Fixed ($) full row/column references #3306

wants to merge 3 commits into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 30, 2023

Description:

Fixed full cols/rows references ($1:$1, $A:$A) do not work properly. See commit messsages.

Task: : 3571633

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3227

@LucasLefevre
[FIX] tokenizer: recognized fixed full headers
ed37bca 
References with a fixed ($) right-hand part such as "1:$1", "A:$A"
or "$B$2:$2" are not recognized as REFERENCE tokens.

Task: 3571633
X-original-commit: c6ec93a
@LucasLefevre
[FIX] composer: loop fixed full references
b055667 
Given the formula `=SUM(1:5)`, press F4 with you cursor on the reference
to fix the references.
=> the result is `$$1:$$5` instead of `$1:$5`

There's a similar issue with full column references.

Task: 3571633
X-original-commit: d814cd8
@LucasLefevre
[FIX] ranges: allow single full col references
fb511e2 
Type in a cell `=SUM($F$2:F)`
=> the formula becomes `=SUM($F$2:$F)`
   The right-hand part is fixed automatically. There's no reason
   to do that.

Task: 3571633
X-original-commit: 78d5af1
@robodoo
Copy link
Collaborator

robodoo commented Nov 30, 2023

Pull request status dashboard.

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 30, 2023

This PR targets saas-16.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot fw-bot mentioned this pull request Nov 30, 2023
Closed
14 tasks
robodoo pushed a commit that referenced this pull request Dec 1, 2023
@LucasLefevre
[FIX] tokenizer: recognized fixed full headers
acedfb0 
References with a fixed ($) right-hand part such as "1:$1", "A:$A"
or "$B$2:$2" are not recognized as REFERENCE tokens.

Task: 3571633
X-original-commit: c6ec93a
Part-of: #3306
robodoo pushed a commit that referenced this pull request Dec 1, 2023
@LucasLefevre
[FIX] composer: loop fixed full references
aafbcb3 
Given the formula `=SUM(1:5)`, press F4 with you cursor on the reference
to fix the references.
=> the result is `$$1:$$5` instead of `$1:$5`

There's a similar issue with full column references.

Task: 3571633
X-original-commit: d814cd8
Part-of: #3306
robodoo pushed a commit that referenced this pull request Dec 1, 2023
@LucasLefevre
[FIX] ranges: allow single full col references
56d54ad 
Type in a cell `=SUM($F$2:F)`
=> the formula becomes `=SUM($F$2:$F)`
   The right-hand part is fixed automatically. There's no reason
   to do that.

closes #3306

Task: 3571633
X-original-commit: 78d5af1
Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this Dec 1, 2023
@fw-bot fw-bot deleted the saas-16.2-16.0-fixed-references-lul-5ZAB-fw branch December 15, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
forwardport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fw-bot @robodoo @LucasLefevre