Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][FIX] Fixed ($) full row/column references #3306

Closed
wants to merge 3 commits into from
Closed

[FW][FIX] Fixed ($) full row/column references #3306

wants to merge 3 commits into from

Commits on Nov 30, 2023

  1. [FIX] tokenizer: recognized fixed full headers 

    References with a fixed ($) right-hand part such as "1:$1", "A:$A"
or "$B$2:$2" are not recognized as REFERENCE tokens.

Task: 3571633
X-original-commit: c6ec93a
    @LucasLefevre
    LucasLefevre committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    ed37bca View commit details
    Browse the repository at this point in the history

  2. [FIX] composer: loop fixed full references 

    Given the formula `=SUM(1:5)`, press F4 with you cursor on the reference
to fix the references.
=> the result is `$$1:$$5` instead of `$1:$5`

There's a similar issue with full column references.

Task: 3571633
X-original-commit: d814cd8
    @LucasLefevre
    LucasLefevre committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    b055667 View commit details
    Browse the repository at this point in the history

  3. [FIX] ranges: allow single full col references 

    Type in a cell `=SUM($F$2:F)`
=> the formula becomes `=SUM($F$2:$F)`
   The right-hand part is fixed automatically. There's no reason
   to do that.

Task: 3571633
X-original-commit: 78d5af1
    @LucasLefevre
    LucasLefevre committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    fb511e2 View commit details
    Browse the repository at this point in the history