[FIX] BottomBarSheet: renaming a sheet with styled content #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasLefevre
reviewed
Jan 2, 2024
| @@ -185,7 +185,18 @@ export class BottomBarSheet extends Component<Props, SpreadsheetChildEnv> { | |||
| } | |||
|
|
|||
| private getInputContent(): string | undefined | null { | |||
| return this.sheetNameRef.el?.textContent; | |||
| const element = this.sheetNameRef.el; | |||
There was a problem hiding this comment.
I think we can use contenteditable="plaintext-only" and it would avoid the issue right ?
diff --git a/src/components/bottom_bar_sheet/bottom_bar_sheet.xml b/src/components/bottom_bar_sheet/bottom_bar_sheet.xml
index 98de053af..b79f68091 100644
--- a/src/components/bottom_bar_sheet/bottom_bar_sheet.xml
+++ b/src/components/bottom_bar_sheet/bottom_bar_sheet.xml
@@ -19,7 +19,7 @@
t-on-dblclick="() => this.onDblClick()"
t-on-focusout="() => this.onFocusOut()"
t-on-keydown="(ev) => this.onKeyDown(ev)"
- t-att-contenteditable="state.isEditing.toString()"
+ t-att-contenteditable="state.isEditing ? 'plaintext-only': '0'"
/>
<span class="o-sheet-icon ms-1" t-on-click.stop="(ev) => this.onIconClick(ev)">
<t t-call="o-spreadsheet-Icon.TRIANGLE_DOWN"/>There was a problem hiding this comment.
Absolutely, @LucasLefevre, Updated the code. Thank you for the input!
dhrp-odoo
force-pushed
the
saas-16.2-fix-traceback-rename-sheet-dhrp
branch
from
bd9ab3c
to
2be636c
Compare
Modified the span element to be contenteditable in plain-text only, resolving the traceback issue during sheet renaming. Task:: 3621086
dhrp-odoo
force-pushed
the
saas-16.2-fix-traceback-rename-sheet-dhrp
branch
from
2be636c
to
c3a5147
Compare
LucasLefevre
approved these changes
Jan 26, 2024
robodoo
pushed a commit
that referenced
this pull request
Jan 26, 2024
Modified the span element to be contenteditable in plain-text only, resolving the traceback issue during sheet renaming. Task:: 3621086 closes #3351 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
This was referenced Jan 26, 2024
rrahir
added a commit
that referenced
this pull request
Mar 25, 2024
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1] This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition. Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2]) [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility [2]: jsdom/jsdom#1245 Task: 3754944
14 tasks
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2024
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1] This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition. Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2]) [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility [2]: jsdom/jsdom#1245 closes #3894 Task: 3754944 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
14 tasks
rrahir
added a commit
that referenced
this pull request
Mar 25, 2024
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1] This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition. Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2]) [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility [2]: jsdom/jsdom#1245 Task: 3754944 X-original-commit: a11b5dc
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2024
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1] This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition. Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2]) [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility [2]: jsdom/jsdom#1245 closes #3915 Task: 3754944 X-original-commit: a11b5dc Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
14 tasks
rrahir
added a commit
that referenced
this pull request
Mar 25, 2024
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1] This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition. Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2]) [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility [2]: jsdom/jsdom#1245 Task: 3754944 X-original-commit: 91d7a19
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2024
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1] This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition. Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2]) [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility [2]: jsdom/jsdom#1245 closes #3919 Task: 3754944 X-original-commit: 91d7a19 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
fw-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1] This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition. Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2]) [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility [2]: jsdom/jsdom#1245 Task: 3754944 X-original-commit: ed7d3fa
14 tasks
fw-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1] This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition. Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2]) [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility [2]: jsdom/jsdom#1245 Task: 3754944 X-original-commit: ed7d3fa
14 tasks
fw-bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1] This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition. Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2]) [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility [2]: jsdom/jsdom#1245 Task: 3754944 X-original-commit: ed7d3fa
14 tasks
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2024
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1] This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition. Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2]) [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility [2]: jsdom/jsdom#1245 closes #3922 Task: 3754944 X-original-commit: ed7d3fa Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2024
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1] This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition. Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2]) [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility [2]: jsdom/jsdom#1245 closes #3921 Task: 3754944 X-original-commit: ed7d3fa Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2024
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1] This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition. Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2]) [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility [2]: jsdom/jsdom#1245 closes #3920 Task: 3754944 X-original-commit: ed7d3fa Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Modified the span element to be contenteditable in plain-text only, resolving the traceback issue during sheet renaming.
Task: : 3621086
review checklist