Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] BottomBarSheet: renaming a sheet with styled content #3541

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 29, 2024

Description:

Modified the span element to be contenteditable in plain-text only, resolving the traceback issue during sheet renaming.

Task: : 3621086

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3533
Forward-Port-Of: #3351

Modified the span element to be contenteditable in plain-text only,
resolving the traceback issue during sheet renaming.

Task:: 3621086

X-original-commit: 2fc6313
@robodoo
Copy link
Collaborator

robodoo commented Jan 29, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 29, 2024

This PR targets 17.0 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo closed this in fa95e46 Jan 29, 2024
@fw-bot fw-bot deleted the 17.0-saas-16.2-fix-traceback-rename-sheet-dhrp-_Dtj-fw branch February 12, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants