Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] functions: name MID args #3399

Closed
wants to merge 1 commit into from
Closed

[FIX] functions: name MID args #3399

wants to merge 1 commit into from

Conversation

LucasLefevre
Copy link
Collaborator

@LucasLefevre LucasLefevre commented Jan 9, 2024 •
edited

The names of the second and third arguments of MID are missing.

It makes the composer autocomplete crash if you write "=MID(" because the t-foreach key is duplicated (an empty string)

Mistake from a815a16

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Jan 9, 2024

Pull request status dashboard.

pro-odoo
pro-odoo approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

@LucasLefevre
Copy link
Collaborator Author

LucasLefevre commented Jan 9, 2024 •
edited

robodoo r-
some others are missing

@LucasLefevre
[FIX] functions: name MID args
d198e7b 
Some function arguments are missing their names.

It makes the composer autocomplete crash if you write "=MID("
because the t-foreach key is duplicated (an empty string)

Mistake from a815a16
pro-odoo
pro-odoo approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Jan 9, 2024
@LucasLefevre
[FIX] functions: name MID args
67225a3 
Some function arguments are missing their names.

It makes the composer autocomplete crash if you write "=MID("
because the t-foreach key is duplicated (an empty string)

Mistake from a815a16

closes #3399

Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
@fw-bot fw-bot mentioned this pull request Jan 9, 2024
Closed
14 tasks
@robodoo robodoo closed this Jan 9, 2024
This was referenced Jan 9, 2024
Closed
Closed
Closed
@fw-bot fw-bot deleted the saas-16.2-MID-args-lul branch January 23, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pro-odoo pro-odoo pro-odoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LucasLefevre @robodoo @pro-odoo