Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] functions: name MID args #3403

Closed
wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 9, 2024

The names of the second and third arguments of MID are missing.

It makes the composer autocomplete crash if you write "=MID(" because the t-foreach key is duplicated (an empty string)

Mistake from a815a16

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3399

@robodoo
Copy link
Collaborator

robodoo commented Jan 9, 2024

@fw-bot fw-bot mentioned this pull request Jan 9, 2024
14 tasks
@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 9, 2024

@LucasLefevre @pro-odoo cherrypicking of pull request #3399 failed.

stdout:

Auto-merging src/functions/arguments.ts
Auto-merging src/functions/module_engineering.ts
CONFLICT (content): Merge conflict in src/functions/module_engineering.ts
Auto-merging src/functions/module_financial.ts
CONFLICT (content): Merge conflict in src/functions/module_financial.ts
Auto-merging src/functions/module_text.ts
CONFLICT (content): Merge conflict in src/functions/module_text.ts

stderr:

09:26:42.598310 git.c:463               trace: built-in: git cherry-pick d198e7bcc28e0ff914a14355fcaea7b89e706aa8
error: could not apply d198e7bcc... [FIX] functions: name MID args
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Some function arguments are missing their names.

It makes the composer autocomplete crash if you write "=MID("
because the t-foreach key is duplicated (an empty string)

Mistake from a815a16

X-original-commit: 67225a3
@LucasLefevre LucasLefevre force-pushed the 17.0-saas-16.2-MID-args-lul-oeUG-fw branch from 23abf67 to b003407 Compare January 9, 2024 10:27
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

@robodoo robodoo closed this in 61780b4 Jan 9, 2024
@fw-bot fw-bot mentioned this pull request Jan 9, 2024
14 tasks
@fw-bot fw-bot deleted the 17.0-saas-16.2-MID-args-lul-oeUG-fw branch January 23, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants