[FIX] range: Support ranges with no Rangeparts
#3416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current typing of `RangeImpl.parts` is such that we have to support the presence of 0, 1 or 2 parts defined in the `Range` object. We only supported the last 2 cases. Task: 3608941
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jan 17, 2024
The current typing of `RangeImpl.parts` is such that we have to support the presence of 0, 1 or 2 parts defined in the `Range` object. We only supported the last 2 cases. closes #3416 Task: 3608941 Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current typing of
RangeImpl.partsis such that we have to support the presence of 0, 1 or 2 parts defined in theRangeobject. We only supported the last 2 cases.Task: 3608941
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist