Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] range: Support ranges with no Rangeparts #3459

Closed
wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 17, 2024

The current typing of RangeImpl.parts is such that we have to support the presence of 0, 1 or 2 parts defined in the Range object. We only supported the last 2 cases.

Task: 3608941

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3416

The current typing of `RangeImpl.parts` is such that we have to support
the presence of 0, 1 or 2 parts defined in the `Range` object. We only
supported the last 2 cases.

Task: 3608941
X-original-commit: afc1b33
@robodoo
Copy link
Collaborator

robodoo commented Jan 17, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 17, 2024

This PR targets saas-16.3 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

robodoo pushed a commit that referenced this pull request Jan 17, 2024
The current typing of `RangeImpl.parts` is such that we have to support
the presence of 0, 1 or 2 parts defined in the `Range` object. We only
supported the last 2 cases.

closes #3459

Task: 3608941
X-original-commit: afc1b33
Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
@robodoo robodoo closed this Jan 17, 2024
@fw-bot fw-bot deleted the saas-16.3-16.0-fix-range-parts-rar-ShQC-fw branch January 31, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants