Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] formatting: do not show escape character #3497

Closed
wants to merge 1 commit into from
Closed

[FIX] formatting: do not show escape character #3497

wants to merge 1 commit into from

Conversation

LucasLefevre
Copy link
Collaborator

Description:

If you want to use double quotes in a string which is part of a formula, you have to escape it using a backslash (="hello "world"") However, the backslash is shown when displaying the cell content.

Task: : 3698283

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@LucasLefevre
[FIX] formatting: do not show escape character
74321a8 
If you want to use double quotes in a string which is part of a formula, you
have to escape it using a backslash (="hello \"world\"")
However, the backslash is shown when displaying the cell content.

Task: 3698283
@robodoo
Copy link
Collaborator

robodoo commented Jan 23, 2024

Pull request status dashboard.

pro-odoo
pro-odoo approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Jan 29, 2024
@LucasLefevre
[FIX] formatting: do not show escape character
88ea76d 
If you want to use double quotes in a string which is part of a formula, you
have to escape it using a backslash (="hello \"world\"")
However, the backslash is shown when displaying the cell content.

closes #3497

Task: 3698283
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
@robodoo robodoo closed this Jan 29, 2024
This was referenced Jan 29, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Feb 2, 2024

@LucasLefevre @pro-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

3 similar comments
@fw-bot
Copy link
Collaborator

fw-bot commented Feb 3, 2024

@LucasLefevre @pro-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented Feb 4, 2024

@LucasLefevre @pro-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented Feb 5, 2024

@LucasLefevre @pro-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

This was referenced Feb 5, 2024
Closed
Closed
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Feb 6, 2024

@LucasLefevre @pro-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot fw-bot deleted the 15.0-format-escape-lul branch February 12, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pro-odoo pro-odoo pro-odoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LucasLefevre @robodoo @fw-bot @pro-odoo