Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] formatting: do not show escape character #3565

Closed
wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 29, 2024

Description:

If you want to use double quotes in a string which is part of a formula, you have to escape it using a backslash (="hello "world"") However, the backslash is shown when displaying the cell content.

Task: : 3698283

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #3560
Forward-Port-Of: #3497

@robodoo
Copy link
Collaborator

robodoo commented Jan 29, 2024

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 29, 2024

This PR targets saas-16.4 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 29, 2024

@LucasLefevre @pro-odoo ci/runbot failed on this forward-port PR

If you want to use double quotes in a string which is part of a formula, you
have to escape it using a backslash (="hello \"world\"")
However, the backslash is shown when displaying the cell content.

Task: 3698283
X-original-commit: 050b3ac
@LucasLefevre LucasLefevre force-pushed the saas-16.4-15.0-format-escape-lul-gVIe-fw branch from eec73c3 to fe8974c Compare February 5, 2024 07:30
@fw-bot
Copy link
Collaborator Author

fw-bot commented Feb 5, 2024

@LucasLefevre @pro-odoo this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo)

@LucasLefevre
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 5, 2024
If you want to use double quotes in a string which is part of a formula, you
have to escape it using a backslash (="hello \"world\"")
However, the backslash is shown when displaying the cell content.

closes #3565

Task: 3698283
X-original-commit: 050b3ac
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this Feb 5, 2024
@fw-bot fw-bot deleted the saas-16.4-15.0-format-escape-lul-gVIe-fw branch February 19, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants